From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B3FD45A6E for ; Tue, 18 Sep 2018 16:21:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 07:21:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,389,1531810800"; d="scan'208";a="233917601" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 18 Sep 2018 07:21:27 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 07:21:01 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Sep 2018 07:21:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Tue, 18 Sep 2018 22:20:41 +0800 From: "Zhang, Qi Z" To: "Ye, Xiaolong" , "Wang, Xiao W" CC: "Bie, Tiwei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready Thread-Index: AQHUS8rPWOb5w4jVsUi/EpstD57cyaTu78cAgActsAA= Date: Tue, 18 Sep 2018 14:20:41 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153287C6C@SHSMSX103.ccr.corp.intel.com> References: <20180910110531.138449-1-xiao.w.wang@intel.com> <20180914012517.44977-1-xiao.w.wang@intel.com> <20180914084132.GA23570@intel.com> In-Reply-To: <20180914084132.GA23570@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjhhN2RhZGEtZmZjNy00ZWZlLTg0YTYtZGY3MjA1MDY0N2M4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWFJMZzV0U0ZwWmx2XC9tKzZINkkra212RUVCalNoOXh5TjhsXC9EYlhRV3ZLK2RhUFI0d3dmWWRBOW82YmQ1TG1LIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 14:21:31 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Friday, September 14, 2018 4:42 PM > To: Wang, Xiao W > Cc: Bie, Tiwei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready >=20 > Looks good to me. >=20 > Reviewed-by: Ye Xiaolong >=20 > Thanks, > Xiaolong >=20 > On 09/14, Xiao Wang wrote: > >If the device is not clearly reset by the previous driver and holds > >some invalid ring addr, and the relay thread kicks it before HW is > >properly re-configured, a bad DMA request may happen. > > > >Besides, the notify_addr which is used by the relay thread is set in > >the vdpa_ifcvf_start function, if a kick relay happens before > >vdpa_ifcvf_start finishes, a null addr is accessed. > > > >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > > > >Signed-off-by: Xiao Wang Applied to dpdk-next-net-intel. Thanks Qi