From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1D9551E2F for ; Tue, 16 Oct 2018 18:41:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 09:41:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,389,1534834800"; d="scan'208";a="100730223" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 16 Oct 2018 09:41:58 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 09:41:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 09:41:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 00:41:55 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , "gaetan.rivet@6wind.com" , "Burakov, Anatoly" , "arybchenko@solarflare.com" , "Ananyev, Konstantin" , "Richardson, Bruce" , "Yigit, Ferruh" , "Shelton, Benjamin H" , "Vangati, Narender" Thread-Topic: [dpdk-dev] [PATCH v17 0/6] enable hotplug on multi-process Thread-Index: AQHUZOVcw6CtjT6i/0y/Ay/i9a5afqUhLLMAgADmPfA= Date: Tue, 16 Oct 2018 16:41:55 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532C21B7@SHSMSX103.ccr.corp.intel.com> References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20181016001632.65357-1-qi.z.zhang@intel.com> <6323427.7gbbtosImR@xps> In-Reply-To: <6323427.7gbbtosImR@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQwMjJlZDQtYTFkYi00ZjM5LWEyNzUtNmVkMTk5YjAzOWUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOWVqYSt0ZmpQaHlRRloxdTkrbUF0UDh5YkNUSmYzaFd6UGFNYW1nZDY5OVo5TEoyaGJHdVZ2dGZreUIxMW9MaSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v17 0/6] enable hotplug on multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 16:42:00 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, October 16, 2018 3:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; gaetan.rivet@6wind.com; Burakov, Anatoly > ; arybchenko@solarflare.com; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; > Shelton, Benjamin H ; Vangati, Narender > > Subject: Re: [dpdk-dev] [PATCH v17 0/6] enable hotplug on multi-process >=20 > > Qi Zhang (6): > > ethdev: add function to release port in secondary process > > eal: enable hotplug on multi-process > > eal: support attach or detach share device from secondary > > drivers/net: enable hotplug on secondary process > > drivers/net: enable device detach on secondary > > examples/multi_process: add hotplug sample > > > > doc/guides/rel_notes/release_18_11.rst | 13 + > > drivers/net/af_packet/rte_eth_af_packet.c | 6 +- > > drivers/net/bnxt/bnxt_ethdev.c | 6 +- > > drivers/net/bonding/rte_eth_bond_pmd.c | 6 +- > > drivers/net/ena/ena_ethdev.c | 2 +- > > drivers/net/kni/rte_eth_kni.c | 6 +- > > drivers/net/liquidio/lio_ethdev.c | 2 +- > > drivers/net/null/rte_eth_null.c | 6 +- > > drivers/net/octeontx/octeontx_ethdev.c | 8 + > > drivers/net/pcap/rte_eth_pcap.c | 6 +- > > drivers/net/tap/rte_eth_tap.c | 8 +- > > drivers/net/vhost/rte_eth_vhost.c | 6 +- > > drivers/net/virtio/virtio_ethdev.c | 2 +- > > examples/multi_process/Makefile | 1 + > > examples/multi_process/hotplug_mp/Makefile | 23 ++ > > examples/multi_process/hotplug_mp/commands.c | 214 > ++++++++++++++ > > examples/multi_process/hotplug_mp/commands.h | 10 + > > examples/multi_process/hotplug_mp/main.c | 41 +++ > > lib/librte_eal/bsdapp/eal/Makefile | 1 + > > lib/librte_eal/common/eal_common_dev.c | 254 > ++++++++++++++-- > > lib/librte_eal/common/eal_private.h | 22 ++ > > lib/librte_eal/common/hotplug_mp.c | 426 > +++++++++++++++++++++++++++ > > lib/librte_eal/common/hotplug_mp.h | 46 +++ > > lib/librte_eal/common/include/rte_dev.h | 12 + > > lib/librte_eal/common/include/rte_eal.h | 9 + > > lib/librte_eal/common/meson.build | 1 + > > lib/librte_eal/linuxapp/eal/Makefile | 1 + > > lib/librte_eal/linuxapp/eal/eal.c | 6 + > > lib/librte_ethdev/rte_ethdev.c | 17 +- > > lib/librte_ethdev/rte_ethdev_driver.h | 16 +- > > lib/librte_ethdev/rte_ethdev_pci.h | 10 +- > > lib/librte_ethdev/rte_ethdev_version.map | 7 + > > 32 files changed, 1151 insertions(+), 43 deletions(-) >=20 > Applied, thanks. Thank!=20 >=20 > Note: some PMDs are updated to support multi-process hotplug, but not all > of them. I think you focused on the generic ones (af_packet, pcap, tap, > bonding), but you forgot failsafe. > Please, could you follow-up in -rc2? Thank you As I remember, I've been informed that failsafe is not going to support sec= ondary process, so I remove it as requested. Hi Gaetan: Would you comment on this? Thanks Qi >=20