Re: [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

Hi Jeff:

	
> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, October 11, 2018 4:09 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Guo, Jia
> <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Subject: [PATCH] doc: add known PHY link up issue for i40e
> 
> When application stop i40e nics and quit itself, if i40e nics be rebinded from
> pmd to kernel driver, sometimes PHY can not be link up again any more.

Better use capital letter for NIC , PMD.

s/stop/stops

s/rebinded/rebound

s/can not/cannot


> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
>  doc/guides/rel_notes/known_issues.rst | 27
> +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 95e4ce6..3378bb7 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -759,3 +759,30 @@ Netvsc driver and application restart
> 
>  **Driver/Module**:
>     ``uio_hv_generic`` module.
> +
> +
> +PHY link up failed when rebind i40e nics to kernel driver
> +---------------------------------------------------------
> +
> +**Description**:
> +   When application stop i40e nics and quit itself, if i40e nics be rebinded
> +   from pmd to kernel driver, sometimes PHY can not be link up again any
> more.

Besides the spell, grammar fix as previous, I think the content here should be swapped with the content in **Implication**


> +
> +**Implication**:
> +   when DPDK application quit and invoke the function ``i40e_dev_stop``,
> I40e
> +   pmd will set PHY to be link down. After these unexpected configure
> which not
> +   come from kernel driver, 

Not very clear about this statement.
Are you going to say:

Before DPDK application quit, it will invoke the function ````i40e_dev_stop`` which will set PHY to link down.
This is the situation that some kernel driver may not able to handle link status correctly after it retakes control of the device.

I think some reword is necessary here

> + it will encounter link configure failure by using
> +   kernel driver config tools ``ifconfig``. It is a known PHY link configure

No need "kernel driver config tools ``ifconfig``" , just ``ifconfig`` should be enough

> +   synchronous issue in i40e kernel driver. The fix has been addressed in
> 2.7.4
> +   rc version. So if the i40e kernel driver is < 2.7.4 and before the fix be
> +   backported into the privous versions, use these kernel drivers will
> perhaps
> +   have this issue.


> +
> +**Resolution/Workaround**:
> +   If it does not help by re-insmod kernel driver, please reboot system.

remove and re-insert?

If it does not help by remove and insert i40e kernel driver, please reboot the system.

> +
> +**Affected E0nvironment/Platform**:

Environment 

> +   All.
> +
> +**Driver/Module**:
> +   Poll Mode Driver (PMD).
> --
> 2.7.4