From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 699471B197 for ; Fri, 19 Oct 2018 20:16:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2018 11:16:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,401,1534834800"; d="scan'208";a="272783091" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2018 11:16:45 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Oct 2018 11:16:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 19 Oct 2018 11:16:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.224]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.131]) with mapi id 14.03.0319.002; Sat, 20 Oct 2018 02:16:43 +0800 From: "Zhang, Qi Z" To: Huaibin Wang , "dev@dpdk.org" CC: "Xing, Beilei" , Laurent Hardy Thread-Topic: [PATCH] net/i40e: keep promisc on if allmulticast is enabled Thread-Index: AQHUZQBGryjIQ7NHPku/fLTj5ATMDaUl0MqAgAEUpdA= Date: Fri, 19 Oct 2018 18:16:42 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532CA9C4@SHSMSX103.ccr.corp.intel.com> References: <20181016032737.28869-1-huaibin.wang@6wind.com> <20181019094521.7069-1-huaibin.wang@6wind.com> In-Reply-To: <20181019094521.7069-1-huaibin.wang@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGZiMmQ2NmItMGQ2Ny00NjI0LWJlZTAtYTQ1OTkwMmJjYjgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUG5PdVpadVBvVE9idDdBc1Y3XC8rWFJuSFpGblwvU1wvZlRTOTc4Z3NaTjh2UmhaYlNlUnNtMVlpSnlPUUg4c0dcLzkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2018 18:16:48 -0000 > -----Original Message----- > From: Huaibin Wang [mailto:huaibin.wang@6wind.com] > Sent: Friday, October 19, 2018 2:45 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > huaibin Wang ; Laurent Hardy > > Subject: [PATCH] net/i40e: keep promisc on if allmulticast is enabled >=20 > From: huaibin Wang >=20 > Promisc should not be disabled if the all multicast mode is enabled. > Patch keeps the promiscuous on if all multicast mode is on, this behavior= is > also consistent with the implementation done on ixgbe pmd. >=20 > Signed-off-by: huaibin Wang > Signed-off-by: Laurent Hardy Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Cc: stable@dpdk.org is added. Thanks Qi > --- > Cc: Beilei Xing > Cc: Qi Zhang >=20 > drivers/net/i40e/i40e_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index f7a685c8c..6c503debc 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct > rte_eth_dev *dev) > if (status !=3D I40E_SUCCESS) > PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); >=20 > + /* must remain in all_multicast mode */ > + if (dev->data->all_multicast =3D=3D 1) > + return; > + > status =3D i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, > false, NULL); > if (status !=3D I40E_SUCCESS) > -- > 2.11.0