From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3709369D4 for ; Thu, 25 Oct 2018 17:23:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 08:23:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,424,1534834800"; d="scan'208";a="274404147" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 25 Oct 2018 08:23:46 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 08:23:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 08:23:45 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0415.000; Thu, 25 Oct 2018 23:23:43 +0800 From: "Zhang, Qi Z" To: "Ye, Xiaolong" , "Yan, Zhirun" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask Thread-Index: AQHUbDM/Gzljqpi0FkioYy+6FHdnJqUvDuIAgAEGCcA= Date: Thu, 25 Oct 2018 15:23:43 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532DB769@SHSMSX103.ccr.corp.intel.com> References: <20181025145840.38440-1-zhirun.yan@intel.com> <20181025074528.GC55104@intel.com> In-Reply-To: <20181025074528.GC55104@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzljMzVlYjAtMmIzNC00Njc5LWFkNGEtNWY4OTYxODIzNDg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaEJvaXZ3OE9DVXdyN1RZK2pzVDc0ZThMcUxzek9SQVZuMzl2QURcL2NLTjNVSlZUSktQc1laUjVcL3FMUGhucDVKIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 15:23:50 -0000 > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, October 25, 2018 2:45 AM > To: Yan, Zhirun > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask >=20 > On 10/25, Zhirun Yan wrote: > >Tx offload mask is updated in following commit: commit 1037ed842c37 > >("mbuf: fix Tx offload mask"). Currently, the new added offload flags > >are not supported in PMD and application will fail to call PMD transmit > >prepare function. > > > >This patch updates IXGBE_TX_OFFFLOAD_MASK. > > > >Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask") > > > >Signed-off-by: Zhirun Yan > >--- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..e462a03d8 100644 > >--- a/drivers/net/ixgbe/ixgbe_rxtx.c > >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >@@ -58,6 +58,10 @@ > > #endif > > /* Bit Mask to indicate what bits required for building TX context */ > > #define IXGBE_TX_OFFLOAD_MASK ( \ > >+ PKT_TX_OUTER_IPV6 | \ > >+ PKT_TX_OUTER_IPV4 | \ > >+ PKT_TX_IPV6 | \ > >+ PKT_TX_IPV4 | \ > > PKT_TX_VLAN_PKT | \ > > PKT_TX_IP_CKSUM | \ > > PKT_TX_L4_MASK | \ >=20 > Reviewed-by: Ye Xiaolong Applied to dpdk-next-net-intel. Thanks Qi >=20 > Thanks, > Xiaolong