From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector mode
Date: Fri, 26 Oct 2018 15:49:31 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532DBD8B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181026111136.GD14620@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, October 26, 2018 6:12 AM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector
> mode
>
> On Fri, Oct 26, 2018 at 02:33:27PM +0800, Beilei Xing wrote:
> > Previously, there is instability during vector Rx if descriptor number
> > is not power of 2, e.g. process hang and some Rx packets are
> > unexpectedly empty. That's because vector Rx mode assumes Rx
> > descriptor number is power of 2 when doing bit mask.
> > This patch allows vector mode only when the number of Rx descriptor is
> > power of 2.
> >
> > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage")
> > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >
> Do we not limit our descriptor ring sizes to powers of two anyway?
Is there a
> real need for non-power-of-2 ring sizes?
This is tracked by some Bugzilla, seems someone is using this kind of configure,
and I guess a more flexible queue size configure may help on the platform that have limited cache?
next prev parent reply other threads:[~2018-10-26 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:40 [dpdk-dev] [PATCH] " Beilei Xing
2018-10-25 16:47 ` Zhang, Qi Z
2018-10-26 6:33 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2018-10-26 8:47 ` Ananyev, Konstantin
2018-10-26 15:41 ` Zhang, Qi Z
2018-10-29 1:48 ` Xing, Beilei
2018-10-26 11:11 ` Bruce Richardson
2018-10-26 15:49 ` Zhang, Qi Z [this message]
2018-11-01 5:53 ` [dpdk-dev] [PATCH v3] " Beilei Xing
2018-11-01 11:48 ` Ananyev, Konstantin
2018-11-01 13:13 ` Zhang, Qi Z
2018-11-05 3:18 ` [dpdk-dev] [PATCH v4] " Beilei Xing
2018-11-05 11:05 ` Ananyev, Konstantin
2018-11-05 15:53 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532DBD8B@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).