From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5F9B414EC for ; Tue, 6 Nov 2018 16:46:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 07:46:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,472,1534834800"; d="scan'208";a="106347193" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2018 07:46:13 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 6 Nov 2018 07:46:06 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 6 Nov 2018 07:46:06 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Tue, 6 Nov 2018 23:46:04 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , "gaetan.rivet@6wind.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice Thread-Index: AQHUdWgBdNm8YH3IMkueZLyDXXxNA6VB7W2AgADwpZA= Date: Tue, 6 Nov 2018 15:46:04 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532E0279@SHSMSX103.ccr.corp.intel.com> References: <20181106003150.10560-1-qi.z.zhang@intel.com> <11443385.dze8hbQCXQ@xps> In-Reply-To: <11443385.dze8hbQCXQ@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Q5MDA5NTEtYmM4Yi00ZTFhLWE5NmItMjc3MGY5MmQ1MGUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidkg4QjFUdmVJSG9GVnA1bDdnTk8zSnJWd1VRZFh5bG5JNDRVS2pVdmVGYXdjZFwvNzlvRFZXRDBaZXpSbTF1TTEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 15:46:16 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, November 6, 2018 2:01 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; gaetan.rivet@6wind.com; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice >=20 > Hi, >=20 > 06/11/2018 01:31, Qi Zhang: > > When probe the same device at second time >=20 > Sorry I stop on this first sentence. > How and why do you probe a vdev twice? >=20 >=20 if we do rte_dev_hotplug_add or rte_dev_proble on a probed device. (yes, th= is is not usually what an application want, but it can happen by miss-opera= tion, and this is covered by our test case, it make sense to me that hotplu= g API should be robust enough to handle that situation.) we will failed at the second time as expected,=20 but will not able to detach the device any more, since during the second sc= an, original vdev->device.devargs is corrupted. Btw as Gaetan mentioned below proposal https://mails.dpdk.org/archives/dev/2018-November/118274.html is that will be covered in 18.11, I think it's better to have a fix for thi= s issue in 18.11 anyway.=20 even the proposed idea is not able be covered in this release, we can roll = back the word around fix when its ready. What do you think?