DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Ilya Maximets <i.maximets@samsung.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Laurent Hardy <laurent.hardy@6wind.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: stop link setup alarm handler before device start
Date: Thu, 8 Nov 2018 20:52:47 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532E17C8@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <949e348c-9612-6a4f-ac2c-532af9ee9dd1@intel.com>



> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Thursday, November 8, 2018 4:16 AM
> To: Ilya Maximets <i.maximets@samsung.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Laurent Hardy
> <laurent.hardy@6wind.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: stop link setup alarm handler
> before device start
> 
> On 08-Nov-18 10:24 AM, Ilya Maximets wrote:
> > We should stop alarm handler before resetting the HW to avoid
> > concurrent device reconfiguration.
> >
> > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link
> > update")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> > ---
> 
> Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> I can confirm that this fixes issue with pktgen where init was failing if the link
> wasn't up.

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks for fix and testing.
Qi
> 
> --
> Thanks,
> Anatoly

      reply	other threads:[~2018-11-08 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181108102407eucas1p1333804da3f477295a691da4d82b018ed@eucas1p1.samsung.com>
2018-11-08 10:24 ` Ilya Maximets
2018-11-08 11:16   ` Burakov, Anatoly
2018-11-08 20:52     ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E70611532E17C8@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=i.maximets@samsung.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=laurent.hardy@6wind.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).