From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: adjust the RSS table
Date: Mon, 3 Dec 2018 08:30:58 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532F8B57@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1543820324-65325-1-git-send-email-xiaoyun.li@intel.com>
minor captures inline
Otherwise
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Monday, December 3, 2018 2:59 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH v2] net/i40e: adjust the RSS table
>
> When starting the device, the RSS table is initialized. So the RSS update before
> device_start would be overwitten. This patch allows users to update the RSS
s/ overwitten /overwritten
> reta table before device_start and adjusts the order to set entries sequentially.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> v2:
> * Adds support to update RSS table before device_start.
> * Simplify the codes with rte_bswap32.
> * Polish the commit log.
> ---
> drivers/net/i40e/i40e_ethdev.c | 21 ++++++++++++++-------
> drivers/net/i40e/i40e_ethdev.h | 3 +++
> 2 files changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 552a7a5..fea42b0 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2444,6 +2444,8 @@ i40e_dev_stop(struct rte_eth_dev *dev)
> pf->tm_conf.committed = false;
>
> hw->adapter_stopped = 1;
> +
> + pf->adapter->is_rss_reta_update = 0;
How about rename to rss_reta_updated?
> }
>
> static void
> @@ -4255,6 +4257,8 @@ i40e_dev_rss_reta_update(struct rte_eth_dev *dev,
> }
> ret = i40e_set_rss_lut(pf->main_vsi, lut, reta_size);
>
> + pf->adapter->is_rss_reta_update = 1;
> +
> out:
> rte_free(lut);
>
> @@ -8492,13 +8496,16 @@ i40e_pf_config_rss(struct i40e_pf *pf)
> return -ENOTSUP;
> }
>
> - for (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {
> - if (j == num)
> - j = 0;
> - lut = (lut << 8) | (j & ((0x1 <<
> - hw->func_caps.rss_table_entry_width) - 1));
> - if ((i & 3) == 3)
> - I40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >> 2), lut);
> + if (pf->adapter->is_rss_reta_update == 0) {
> + for (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {
> + if (j == num)
> + j = 0;
> + lut = (lut << 8) | (j & ((0x1 <<
> + hw->func_caps.rss_table_entry_width) - 1));
> + if ((i & 3) == 3)
> + I40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >> 2),
> + rte_bswap32(lut));
> + }
> }
>
> rss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index 11ecfc3..854aada 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -1081,6 +1081,9 @@ struct i40e_adapter {
>
> /* For devargs */
> uint8_t use_latest_vec;
> +
> + /* For RSS reta table update */
> + uint8_t is_rss_reta_update;
> };
>
> /**
> --
> 2.7.4
next prev parent reply other threads:[~2018-12-03 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 1:35 [dpdk-dev] [PATCH] " Xiaoyun Li
2018-12-03 5:29 ` Zhang, Qi Z
2018-12-03 6:58 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-12-03 8:30 ` Zhang, Qi Z [this message]
2018-12-03 8:26 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-12-03 9:25 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532F8B57@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).