From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ivan Malov <Ivan.Malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11
Date: Mon, 10 Dec 2018 07:29:23 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FBEC4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <cc3a64e9-a364-5eb6-6de3-ae6fbaeb8eec@solarflare.com>
Your understand is correct, I saw the issue happens on both 17.11 and 16.11 both
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Monday, December 10, 2018 2:57 PM
To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org; Ivan Malov <Ivan.Malov@oktetlabs.ru>
Subject: Incorrectly applied ethdev: fix queue start to 17.11
Hi,
Do I understand correctly that the following patch was incorrectly applied
on 17.11 since changes are done in queue stop functions instead of
queue start functions? If so, could you fix it, please. Also I think it makes
sense to check other stable branches as well.
We observe regressions because of the changeset.
Andrew.
commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82
Author: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Date: Thu Mar 22 20:59:01 2018 +0800
ethdev: fix queue start
[ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]
Device must be started before start any queue.
Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com><mailto:konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2018-12-10 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 6:56 Andrew Rybchenko
2018-12-10 7:29 ` Zhang, Qi Z [this message]
2018-12-14 20:10 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FBEC4@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=Ivan.Malov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).