From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E3A601B122 for ; Mon, 10 Dec 2018 13:36:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2018 04:36:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,338,1539673200"; d="scan'208";a="109172064" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 10 Dec 2018 04:36:28 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Dec 2018 04:36:28 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Mon, 10 Dec 2018 20:36:26 +0800 From: "Zhang, Qi Z" To: "Yan, Zhirun" , "dev@dpdk.org" , "Wang, Haiyue" Thread-Topic: [PATCH v1] net/i40e: remove redundant code in free queues. Thread-Index: AQHUkEzlQyuMvjmbUUyenDzaewH3paV35+9Q Date: Mon, 10 Dec 2018 12:36:26 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FC030@SHSMSX103.ccr.corp.intel.com> References: <20181210133205.70401-1-zhirun.yan@intel.com> In-Reply-To: <20181210133205.70401-1-zhirun.yan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTEzZTQxMzgtNTA2Yy00NGQ5LTg4ZjAtZGNkOTVhMGU1YThkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2l5Wk1JZkpXM0g1Q0ZiVTdxSnZGb2dCXC8rSk11TDlGTmwybFFoUWtYZXpSeEY5ZWNcL1B3dXhlc1kwajY4M3lJIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove redundant code in free queues. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 12:36:30 -0000 > -----Original Message----- > From: Yan, Zhirun > Sent: Monday, December 10, 2018 9:32 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue > > Cc: Yan, Zhirun > Subject: [PATCH v1] net/i40e: remove redundant code in free queues. >=20 > Before this patch, there are two functions that will clear RX/TX queues > number: rte_eth_dev_close() and i40e_dev_free_queues(). I agree with what the patch changed, but the commit log is not comprehensiv= e. I40e_dev_free_queues is not only in the path of rte_eth_dev_close but also = rte_eth_dev_reset. So For rte_eth_dev_close, its redundant because of duplication. For rte_eth_dev_reset its redundant because of not necessary, since followi= ng dev_configure is required after dev_reset and it will be updated correct= ly. >=20 > This patch remove redundant code in i40e_dev_free_queues(). >=20 > Signed-off-by: Zhirun Yan > Signed-off-by: Haiyue Wang > --- > drivers/net/i40e/i40e_rxtx.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > e1152ff0e..cc953ad58 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) > i40e_dev_rx_queue_release(dev->data->rx_queues[i]); > dev->data->rx_queues[i] =3D NULL; > } > - dev->data->nb_rx_queues =3D 0; >=20 > for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > if (!dev->data->tx_queues[i]) > @@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) > i40e_dev_tx_queue_release(dev->data->tx_queues[i]); > dev->data->tx_queues[i] =3D NULL; > } > - dev->data->nb_tx_queues =3D 0; > } >=20 > #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC > -- > 2.17.1