From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EECD91B118 for ; Mon, 10 Dec 2018 15:08:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2018 06:08:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,338,1539673200"; d="scan'208";a="302568773" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 10 Dec 2018 06:08:32 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Dec 2018 06:08:31 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Dec 2018 06:08:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.176]) with mapi id 14.03.0415.000; Mon, 10 Dec 2018 22:08:29 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Yan, Zhirun" , "dev@dpdk.org" Thread-Topic: [PATCH v1] net/i40e: remove redundant code in free queues. Thread-Index: AQHUkEzlQyuMvjmbUUyenDzaewH3paV35+9Q//9+UgCAAI+HwA== Date: Mon, 10 Dec 2018 14:08:29 +0000 Message-ID: <039ED4275CED7440929022BC67E70611532FC0A6@SHSMSX103.ccr.corp.intel.com> References: <20181210133205.70401-1-zhirun.yan@intel.com> <039ED4275CED7440929022BC67E70611532FC030@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTEzZTQxMzgtNTA2Yy00NGQ5LTg4ZjAtZGNkOTVhMGU1YThkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2l5Wk1JZkpXM0g1Q0ZiVTdxSnZGb2dCXC8rSk11TDlGTmwybFFoUWtYZXpSeEY5ZWNcL1B3dXhlc1kwajY4M3lJIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove redundant code in free queues. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 14:08:33 -0000 > -----Original Message----- > From: Wang, Haiyue > Sent: Monday, December 10, 2018 8:47 PM > To: Zhang, Qi Z ; Yan, Zhirun ; > dev@dpdk.org > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues. >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, December 10, 2018 20:36 > > To: Yan, Zhirun ; dev@dpdk.org; Wang, Haiyue > > > > Subject: RE: [PATCH v1] net/i40e: remove redundant code in free queues. > > > > > > > > > -----Original Message----- > > > From: Yan, Zhirun > > > Sent: Monday, December 10, 2018 9:32 PM > > > To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue > > > > > > Cc: Yan, Zhirun > > > Subject: [PATCH v1] net/i40e: remove redundant code in free queues. > > > > > > Before this patch, there are two functions that will clear RX/TX > > > queues > > > number: rte_eth_dev_close() and i40e_dev_free_queues(). > > > > I agree with what the patch changed, but the commit log is not > comprehensive. > > I40e_dev_free_queues is not only in the path of rte_eth_dev_close but > > also rte_eth_dev_reset. > > So > > For rte_eth_dev_close, its redundant because of duplication. > > For rte_eth_dev_reset its redundant because of not necessary, since > > following dev_configure is required after dev_reset and it will be upda= ted > correctly. > > >=20 > How about this commit message ? >=20 > net/i40e: queue management data set is out of the API scope. >=20 > Function i40e_dev_free_queues is used to free specific i40e queue entries= , but > should not be used to set the upper level queue management data in 'struc= t > rte_eth_dev_data', such as ' nb_rx/tx_queues ', which are maintained by > 'rte_eth_dev_rx/tx_queue_config'. Ideally it should be what you described , but if you look at exist code in = different PMD nb_rx/tx_queues is modified anywhere. so I'm not very sure if nb_rx/tx_queues should only be modified in rte_ethd= ev_rx/tx_queue_config is the original design, and I don't have confidence t= hose cleanup is always correct,=20 that's why I will prefer an explanation that prove this code clean is corre= ct. I think your comment is much fit for a patch set that do all the cleanu= p. >=20 > > > > > > This patch remove redundant code in i40e_dev_free_queues(). > > > > > > Signed-off-by: Zhirun Yan > > > Signed-off-by: Haiyue Wang > > > --- > > > drivers/net/i40e/i40e_rxtx.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > > b/drivers/net/i40e/i40e_rxtx.c index > > > e1152ff0e..cc953ad58 100644 > > > --- a/drivers/net/i40e/i40e_rxtx.c > > > +++ b/drivers/net/i40e/i40e_rxtx.c > > > @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) > > > i40e_dev_rx_queue_release(dev->data->rx_queues[i]); > > > dev->data->rx_queues[i] =3D NULL; > > > } > > > - dev->data->nb_rx_queues =3D 0; > > > > > > for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > > > if (!dev->data->tx_queues[i]) > > > @@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) > > > i40e_dev_tx_queue_release(dev->data->tx_queues[i]); > > > dev->data->tx_queues[i] =3D NULL; > > > } > > > - dev->data->nb_tx_queues =3D 0; > > > } > > > > > > #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC > > > -- > > > 2.17.1