From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Didier Pallard <didier.pallard@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: revert fix offload not supported mask
Date: Thu, 13 Dec 2018 09:47:08 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FE57A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181211172501.31467-1-didier.pallard@6wind.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Didier Pallard
> Sent: Wednesday, December 12, 2018 1:25 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: revert fix offload not supported mask
>
> This reverts
> commit 09a62d75691f ("net/i40e: fix offload not supported mask")
>
> Contrary to what is said in above patch commit log,
> I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part of
> PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK.
> Above patch erroneously includes all PKT_RX_OFFLOAD_ bits in the
> I40E_TX_OFFLOAD_NOTSUP_MASK, this is not what is expected.
> Restore the initial xor that gives the expected result.
>
> Fixes: 09a62d75691f ("net/i40e: fix offload not supported mask")
> Cc: stable@dpdk.org
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel
Thanks
Qi
prev parent reply other threads:[~2018-12-13 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 17:25 Didier Pallard
2018-12-11 22:01 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-12-12 3:03 ` Zhang, Qi Z
2018-12-12 6:17 ` Ye Xiaolong
2018-12-13 9:47 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FE57A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).