From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7419B1BC92; Thu, 20 Dec 2018 13:31:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 04:31:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,376,1539673200"; d="scan'208";a="103381314" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 20 Dec 2018 04:31:01 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 20 Dec 2018 04:31:01 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 20 Dec 2018 04:31:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Thu, 20 Dec 2018 20:30:58 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Burakov, Anatoly" , "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [PATCH] eal: close MP socket during cleanup Thread-Index: AQHUl24JxA5QahNCwkC7aczl78+lmKWFObEAgAJU8lA= Date: Thu, 20 Dec 2018 12:30:59 +0000 Message-ID: <039ED4275CED7440929022BC67E706115330378C@SHSMSX103.ccr.corp.intel.com> References: <20181219074107.10084-1-qi.z.zhang@intel.com> <3200108.0fENqxW6u2@xps> In-Reply-To: <3200108.0fENqxW6u2@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDRlNjk5YmYtNjUyZS00YWU1LWEyZGEtNDBhMWQ0ZDdiMDgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1lFc1hVRGlRcE1EY2dISFdVUVVQMTFkR3NsMktjZ0x2VVwvTHBncHFWSE04TGhHSHhaMThWbDhZZUY3TTVnajgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: close MP socket during cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 12:31:03 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, December 19, 2018 4:46 PM > To: Zhang, Qi Z > Cc: Burakov, Anatoly ; dev@dpdk.org; Yigit, Fe= rruh > ; stable@dpdk.org > Subject: Re: [PATCH] eal: close MP socket during cleanup >=20 > 19/12/2018 08:41, Qi Zhang: > > When secondary process quit, the mp_socket* file still exist, that > > cause rte_mp_request_sync fail when try to send message on a floating > > socket. > > > > The patch fix the issue by introduce a function rte_mp_channel_fini. > > This function will be called by rte_eal_cleanup and it will close the > > mp socket and delete the mp_socket* file. >=20 > Why not call it rte_mp_channel_cleanup, keeping the same wording? Just some memory in my mind that "fini" is in fashion recently, but seems I= 'm wrong :) >=20 > [...] > > --- a/lib/librte_eal/linuxapp/eal/eal.c > > +++ b/lib/librte_eal/linuxapp/eal/eal.c > > @@ -1229,6 +1229,7 @@ rte_eal_cleanup(void) > > if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY) > > rte_memseg_walk(mark_freeable, NULL); > > rte_service_finalize(); > > + rte_mp_channel_fini(); > > return 0; > > } >=20 > Should be called in bsdapp/eal? Yes, it should, will add in v2. Thanks Qi >=20