From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 626601B13B; Wed, 2 Jan 2019 03:26:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2019 18:26:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,429,1539673200"; d="scan'208";a="130752903" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 01 Jan 2019 18:26:00 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 18:26:00 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 18:25:59 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 10:25:56 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Lu, Wenzhuo" , "Peng, Yuan" Thread-Topic: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter Thread-Index: AQHUnBiNPYfGx6mlOE+p3QwKlp/e4qWbNi3A//+HcwCAAIuWwA== Date: Wed, 2 Jan 2019 02:25:56 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153310A1E@SHSMSX103.ccr.corp.intel.com> References: <1545025982-2065-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-1-git-send-email-wei.zhao1@intel.com> <1545716688-34608-2-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzUzYjUzZGItM2E2Ni00ZmE0LWJhNDQtZGRlMzFjMTEzMzkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQTdFa3Q0cktIUUI4VTBjMCs4T3RwcitaY3haM05SN0dzSlBzdUlxd1lQck45aXY3a2E1ZzNvRndqcVNFYzNTbSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 02:26:02 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, January 2, 2019 9:54 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: stable@dpdk.org; Lu, Wenzhuo ; Peng, Yuan > > Subject: RE: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter >=20 > Hi, qi >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, January 2, 2019 9:19 AM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Peng, Yuan > > > > Subject: RE: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte > > filter > > > > HI Wei: > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Tuesday, December 25, 2018 1:45 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z > > > ; Peng, Yuan ; Zhao1, Wei > > > > > > Subject: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter > > > > > > There is need for users to use flexible byte filter on x550. > > > x550 support IP mode and tunnel mode flexible byte filter. > > > tunnel mode flexible byte filter is used for vxlan packets and so on. > > > It can be used combined with FDIR tunnel filter. > > > By now, ixgbe PMD flow parer code do not support tunnel mode > > > flexible byte filter for x550, So I have to enable it in function > > ixgbe_parse_fdir_filter_tunnel(). > > > Although IP mode flexible byte filter parser is support in function > > > ixgbe_parse_fdir_filter_normal(), but some flow like "flow create 0 > > > ingress pattern raw pattern is 0xab / end actions queue index 3 / end= " > > > need to be support, so parser code also need change a little. > > > This patch enable all of these feature. > > > > I would suggest to divide this patch into 3 patches 1. more accurate > > input set mask setup (include all changes in ixgbe_fdir.c) 2. support > > flexbyte without IP layer (include changes in > > ixgbe_parse_fdir_filter_normal) 3. support flexbyte in tunnel mode > > (include changes in ixgbe_parse_fdir_flilter_tunnel) > > > > Btw, please make sure to sync the acceptable flow pattern/action > > description above function ixgbe_parse_fdir_filter_xxxxx to their new > > behaviors >=20 > There will be 4 patch in this set, because there is other for flow_cmdlin= e parser, > is that ok? it's better to separate patch 4, it's for cmdline enhancement, not driver r= elated, it can be reviewed, merged independently.=20 >=20 > > > > Thanks > > Qi