From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 99B222C0C; Fri, 1 Mar 2019 08:53:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2019 23:53:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,426,1544515200"; d="scan'208";a="303512135" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 28 Feb 2019 23:53:35 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Feb 2019 23:53:16 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000; Fri, 1 Mar 2019 15:53:14 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF Thread-Index: AQHUw3AbwpXrt5BTJECBGD0NRCyMHKX2f7lA Date: Fri, 1 Mar 2019 07:53:14 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153346B54@SHSMSX103.ccr.corp.intel.com> References: <1547614920-59680-1-git-send-email-wei.zhao1@intel.com> <1550042334-60187-1-git-send-email-wei.zhao1@intel.com> <1550042334-60187-2-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1550042334-60187-2-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjMxMGZlZmMtYTJkMy00MWE1LTkxYTMtYWY2M2FiNzVlNGUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFwvUHIwbUQ5YkZPMXVtNm5ZS0NJS0FvN05uYmZDYytyTGRKWUJOTXduVmtuM21lY053SEJWbmx6OHNMNkNTXC96In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 07:53:38 -0000 HI > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, February 13, 2019 3:19 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF >=20 > There is need to enable two ops of promiscuous_enable and > promiscuous_disable on VF. Should we add something to the release note? This looks like a common featu= re enabling for a wildly used device, users may need to be notified for thi= s features. Thanks Qi >=20 > Signed-off-by: Wei Zhao > --- > doc/guides/nics/features/ixgbe_vf.ini | 1 + > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++ > 2 files changed, 21 insertions(+) >=20 > diff --git a/doc/guides/nics/features/ixgbe_vf.ini > b/doc/guides/nics/features/ixgbe_vf.ini > index 0a15500..1614190 100644 > --- a/doc/guides/nics/features/ixgbe_vf.ini > +++ b/doc/guides/nics/features/ixgbe_vf.ini > @@ -11,6 +11,7 @@ Jumbo frame =3D Y > Scattered Rx =3D Y > LRO =3D Y > TSO =3D Y > +Promiscuous mode =3D Y > Allmulticast mode =3D Y > Unicast MAC filter =3D Y > RSS hash =3D Y > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 7493110..f36064d 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -260,6 +260,8 @@ static int ixgbevf_dev_rx_queue_intr_disable(struct > rte_eth_dev *dev, static void ixgbevf_set_ivar_map(struct ixgbe_hw *hw, > int8_t direction, > uint8_t queue, uint8_t msix_vector); static void > ixgbevf_configure_msix(struct rte_eth_dev *dev); > +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev); > +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev); > static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev); s= tatic > void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev); >=20 > @@ -596,6 +598,8 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = =3D { > .xstats_get_names =3D ixgbevf_dev_xstats_get_names, > .dev_close =3D ixgbevf_dev_close, > .dev_reset =3D ixgbevf_dev_reset, > + .promiscuous_enable =3D ixgbevf_dev_promiscuous_enable, > + .promiscuous_disable =3D ixgbevf_dev_promiscuous_disable, > .allmulticast_enable =3D ixgbevf_dev_allmulticast_enable, > .allmulticast_disable =3D ixgbevf_dev_allmulticast_disable, > .dev_infos_get =3D ixgbevf_dev_info_get, > @@ -8301,6 +8305,22 @@ ixgbe_dev_udp_tunnel_port_del(struct rte_eth_dev > *dev, } >=20 > static void > +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) { > + struct ixgbe_hw *hw =3D > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + > + hw->mac.ops.update_xcast_mode(hw, > IXGBEVF_XCAST_MODE_PROMISC); } > + > +static void > +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) { > + struct ixgbe_hw *hw =3D > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + > + hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE); } > + > +static void > ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev) { > struct ixgbe_hw *hw =3D > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > -- > 2.7.5