From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 730B14C93; Tue, 26 Mar 2019 13:41:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 05:41:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="158504997" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2019 05:41:31 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 05:41:31 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 05:41:30 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Tue, 26 Mar 2019 20:41:29 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH v3] net/i40e: log when provided RSS key is not valid Thread-Index: AQHU47LDuHbIppCvQkqkhyaBZV6gsKYd2sIw Date: Tue, 26 Mar 2019 12:41:28 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153354AD5@SHSMSX103.ccr.corp.intel.com> References: <1553224009-36918-1-git-send-email-wei.zhao1@intel.com> <1553589324-16990-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1553589324-16990-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhjOTg2NzQtOTkxMC00ZDNjLTg0NmYtYjgzZjJhYzZmMzZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZkFBdkRpU2ZOcFpvRm0rckFWMFkyb1Z6TXhRM2hBbmlBNHpWRjVGaWdyRWZPTHRQUWhEejdPd0NDSHV5c1ZoeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 12:41:33 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, March 26, 2019 4:35 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Zhao1, Wei > Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid >=20 > A log message is required when provided RSS key is not valid so that driv= er will > use the default RSS key. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan >=20 > --- >=20 > v2: > update dev info message >=20 > v3: > update log info > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 63ec813..5472312 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > rss_conf.rss_key =3D (uint8_t *)rss_key_default; > rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > sizeof(uint32_t); > + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using > +default\n"); s/perfect/valid to align with the title Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi > } >=20 > i40e_hw_rss_hash_set(pf, &rss_conf); > -- > 2.7.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2B0F9A05D3 for ; Tue, 26 Mar 2019 13:41:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2A644C94; Tue, 26 Mar 2019 13:41:33 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 730B14C93; Tue, 26 Mar 2019 13:41:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 05:41:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,271,1549958400"; d="scan'208";a="158504997" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2019 05:41:31 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 05:41:31 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 05:41:30 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Tue, 26 Mar 2019 20:41:29 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH v3] net/i40e: log when provided RSS key is not valid Thread-Index: AQHU47LDuHbIppCvQkqkhyaBZV6gsKYd2sIw Date: Tue, 26 Mar 2019 12:41:28 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153354AD5@SHSMSX103.ccr.corp.intel.com> References: <1553224009-36918-1-git-send-email-wei.zhao1@intel.com> <1553589324-16990-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1553589324-16990-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhjOTg2NzQtOTkxMC00ZDNjLTg0NmYtYjgzZjJhYzZmMzZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZkFBdkRpU2ZOcFpvRm0rckFWMFkyb1Z6TXhRM2hBbmlBNHpWRjVGaWdyRWZPTHRQUWhEejdPd0NDSHV5c1ZoeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: log when provided RSS key is not valid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326124128.cf0u0mBn4ibl-Byv0rYR5JX1aQQjtcA0VI5z4wGCUeg@z> > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, March 26, 2019 4:35 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Zhao1, Wei > Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid >=20 > A log message is required when provided RSS key is not valid so that driv= er will > use the default RSS key. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan >=20 > --- >=20 > v2: > update dev info message >=20 > v3: > update log info > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 63ec813..5472312 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > rss_conf.rss_key =3D (uint8_t *)rss_key_default; > rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > sizeof(uint32_t); > + PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using > +default\n"); s/perfect/valid to align with the title Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi > } >=20 > i40e_hw_rss_hash_set(pf, &rss_conf); > -- > 2.7.5