From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <qi.z.zhang@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B41F91B465 for <dev@dpdk.org>; Fri, 5 Apr 2019 09:49:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 00:49:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="137793810" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2019 00:49:17 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 00:49:17 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 00:49:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 15:49:15 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: "Zhao1, Wei" <wei.zhao1@intel.com>, David Harton <dharton@cisco.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation Thread-Index: AQHU6bszMB1xAfCj0E6qJOGtX8IvE6YpL4EAgAQFB3A= Date: Fri, 5 Apr 2019 07:49:13 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153363E84@SHSMSX103.ccr.corp.intel.com> References: <20190403011833.20428-1-dharton@cisco.com> <A2573D2ACFCADC41BB3BE09C6DE313CA07ECE373@PGSMSX103.gar.corp.intel.com> In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07ECE373@PGSMSX103.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGQ4OTc2NjUtYjlkNS00MTEyLTg2NmMtYWMxMTk1MGRkZWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWhUejJTRU9QYUdST2FuOWJ4M3lKcU5LVGNmMWdZN29EelFMVzVWMjdoanZ6ZjNBdlN0NUF4dldsaVwvbnZuUGcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 05 Apr 2019 07:49:20 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, April 3, 2019 10:26 AM > To: David Harton <dharton@cisco.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitatio= n >=20 > HI, >=20 > Why not add some more code > " > if (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER) > dev->data->scattered_rx =3D 1; > " >=20 > Into ixgbevf_dev_rx_init() to enable scatter mode when start device? >=20 >=20 > Reviewed-by: Wei Zhao <wei.zhao1@intel.com> >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > > Sent: Wednesday, April 3, 2019 9:19 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin > > <konstantin.ananyev@intel.com>; David Harton <dharton@cisco.com> > > Subject: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation > > > > Currently, if requested MTU is bigger than mbuf size and scattered > > receive is not enabled, setting MTU to that value fails. > > > > This patch allows setting this special MTU when device is stopped, > > because scattered_rx will be re-configured during next port start and > > driver may enable scattered receive according new MTU value. > > > > After this patch, driver may select different receive function > > automatically after MTU set, according MTU values selected. > > > > Signed-off-by: David Harton <dharton@cisco.com> Applied to dpdk-next-net-intel. Thanks Qi=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DB84EA0679 for <public@inbox.dpdk.org>; Fri, 5 Apr 2019 09:49:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92FEC1B467; Fri, 5 Apr 2019 09:49:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B41F91B465 for <dev@dpdk.org>; Fri, 5 Apr 2019 09:49:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 00:49:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="137793810" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2019 00:49:17 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 00:49:17 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 5 Apr 2019 00:49:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 15:49:15 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: "Zhao1, Wei" <wei.zhao1@intel.com>, David Harton <dharton@cisco.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation Thread-Index: AQHU6bszMB1xAfCj0E6qJOGtX8IvE6YpL4EAgAQFB3A= Date: Fri, 5 Apr 2019 07:49:13 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153363E84@SHSMSX103.ccr.corp.intel.com> References: <20190403011833.20428-1-dharton@cisco.com> <A2573D2ACFCADC41BB3BE09C6DE313CA07ECE373@PGSMSX103.gar.corp.intel.com> In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07ECE373@PGSMSX103.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGQ4OTc2NjUtYjlkNS00MTEyLTg2NmMtYWMxMTk1MGRkZWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWhUejJTRU9QYUdST2FuOWJ4M3lKcU5LVGNmMWdZN29EelFMVzVWMjdoanZ6ZjNBdlN0NUF4dldsaVwvbnZuUGcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190405074913.rWnymO0TQ70iIRrljsfq1Put8Zz3hijPn5Ir9wpyv2U@z> > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, April 3, 2019 10:26 AM > To: David Harton <dharton@cisco.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitatio= n >=20 > HI, >=20 > Why not add some more code > " > if (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER) > dev->data->scattered_rx =3D 1; > " >=20 > Into ixgbevf_dev_rx_init() to enable scatter mode when start device? >=20 >=20 > Reviewed-by: Wei Zhao <wei.zhao1@intel.com> >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton > > Sent: Wednesday, April 3, 2019 9:19 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin > > <konstantin.ananyev@intel.com>; David Harton <dharton@cisco.com> > > Subject: [dpdk-dev] [PATCH] net/ixgbevf: remove MTU setting limitation > > > > Currently, if requested MTU is bigger than mbuf size and scattered > > receive is not enabled, setting MTU to that value fails. > > > > This patch allows setting this special MTU when device is stopped, > > because scattered_rx will be re-configured during next port start and > > driver may enable scattered receive according new MTU value. > > > > After this patch, driver may select different receive function > > automatically after MTU set, according MTU values selected. > > > > Signed-off-by: David Harton <dharton@cisco.com> Applied to dpdk-next-net-intel. Thanks Qi=20