From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 146692C17 for ; Wed, 15 May 2019 09:09:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 00:09:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 15 May 2019 00:09:52 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.7]) with mapi id 14.03.0415.000; Wed, 15 May 2019 15:09:50 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 0/3] fix invalid Tx threshhold setup Thread-Index: AQHVAlucZ3v8ekdrYUuiGOvWZZV/RaZrRiMAgACPa3A= Date: Wed, 15 May 2019 07:09:49 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153381A79@SHSMSX103.ccr.corp.intel.com> References: <20190504092939.25326-1-qi.z.zhang@intel.com> <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBkNjkzYWYtOTA4Ni00OGMwLThkZWEtY2VlYjZkYmY0YjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTlhMjI4eTJrYURqcW1uQ2RlcVlsQ2R4d0pFcEFDdEdidHg2ZGRscThyVTloZzdnVU1RRXBmTWFFU0MxOVZFOSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 07:09:54 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 15, 2019 2:36 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Yang, Qiming ; Ananyev, > Konstantin > Cc: dev@dpdk.org > Subject: RE: [PATCH 0/3] fix invalid Tx threshhold setup >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Saturday, May 4, 2019 5:30 PM > > To: Xing, Beilei ; Lu, Wenzhuo > > ; Yang, Qiming ; Ananyev, > > Konstantin > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 0/3] fix invalid Tx threshhold setup > > > > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > > outdated DD status be checked as tx_next_dd, then segment fault happen > > due to free a NULL mbuf pointer. > > > > The issue usually happens with an aggresive tx_free_thresh, for example= : > > > > ./testpmd -c 0x3 -n 4 -- -i --rxq=3D16 --txq=3D16 --rxd=3D1024 --txd=3D= 1024 -- > > txfreet=3D1020 > > > > The patchset fix this issue on i40e, ixgbe and ice. > > > > Qi Zhang (3): > > net/i40e: fix invalid Tx threshold setup > > net/ice: fix invalid Tx threshold setup > > net/ixgbe: fix invalid Tx threshold setup > > > > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > > 3 files changed, 52 insertions(+), 7 deletions(-) > > > > -- > > 2.13.6 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 95085A00E6 for ; Wed, 15 May 2019 09:09:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90D2634F0; Wed, 15 May 2019 09:09:55 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 146692C17 for ; Wed, 15 May 2019 09:09:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 00:09:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 15 May 2019 00:09:52 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 00:09:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.7]) with mapi id 14.03.0415.000; Wed, 15 May 2019 15:09:50 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 0/3] fix invalid Tx threshhold setup Thread-Index: AQHVAlucZ3v8ekdrYUuiGOvWZZV/RaZrRiMAgACPa3A= Date: Wed, 15 May 2019 07:09:49 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153381A79@SHSMSX103.ccr.corp.intel.com> References: <20190504092939.25326-1-qi.z.zhang@intel.com> <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBkNjkzYWYtOTA4Ni00OGMwLThkZWEtY2VlYjZkYmY0YjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTlhMjI4eTJrYURqcW1uQ2RlcVlsQ2R4d0pFcEFDdEdidHg2ZGRscThyVTloZzdnVU1RRXBmTWFFU0MxOVZFOSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515070949.f_dS_7lE45iOe2l0B7dFijfA1S2Dk7L3hYe5vKwhjbM@z> > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 15, 2019 2:36 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Yang, Qiming ; Ananyev, > Konstantin > Cc: dev@dpdk.org > Subject: RE: [PATCH 0/3] fix invalid Tx threshhold setup >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Saturday, May 4, 2019 5:30 PM > > To: Xing, Beilei ; Lu, Wenzhuo > > ; Yang, Qiming ; Ananyev, > > Konstantin > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 0/3] fix invalid Tx threshhold setup > > > > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > > outdated DD status be checked as tx_next_dd, then segment fault happen > > due to free a NULL mbuf pointer. > > > > The issue usually happens with an aggresive tx_free_thresh, for example= : > > > > ./testpmd -c 0x3 -n 4 -- -i --rxq=3D16 --txq=3D16 --rxd=3D1024 --txd=3D= 1024 -- > > txfreet=3D1020 > > > > The patchset fix this issue on i40e, ixgbe and ice. > > > > Qi Zhang (3): > > net/i40e: fix invalid Tx threshold setup > > net/ice: fix invalid Tx threshold setup > > net/ixgbe: fix invalid Tx threshold setup > > > > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > > 3 files changed, 52 insertions(+), 7 deletions(-) > > > > -- > > 2.13.6 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi