From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C958DA05D3 for ; Wed, 22 May 2019 14:42:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0D5C10BD; Wed, 22 May 2019 14:42:09 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4AACFA69 for ; Wed, 22 May 2019 14:42:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 05:42:06 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 22 May 2019 05:42:06 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 05:42:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.216]) with mapi id 14.03.0415.000; Wed, 22 May 2019 20:42:04 +0800 From: "Zhang, Qi Z" To: "Ergin, Mesut A" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance Thread-Index: AQHVC5/WLBSaKt0SjEmZhwLDjaSjEaZ3H4Vg Date: Wed, 22 May 2019 12:42:03 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153385EC0@SHSMSX103.ccr.corp.intel.com> References: <1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com> <1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com> In-Reply-To: <1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmYwMjViZjktNzEyNS00MGExLTkxYTEtYmJmZGE1ZTNjYWJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFYzanh6WFkyRTY5bmV5QVh3WGVnQVFwZGdFTGpFSml1a0c3WGJHOUdTZWRrMnJ6XC9tbEp5T25PalNLZWFJMjUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Mesut: > -----Original Message----- > From: Ergin, Mesut A > Sent: Thursday, May 16, 2019 12:28 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ergin, Mesut A > Subject: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allo= wance >=20 > When i40e_rx_vec_dev_conf_condition_check_default() determines whether > vector receive functions would be allowed during initialization phase, it= should > honor previously recorded disallowance during configuration phase, and no= t > override simply because it is for the first queue. >=20 > Signed-off-by: Mesut Ali Ergin > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 0e6ffa0..f30cab4 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -212,6 +212,10 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) > return -1; >=20 > + /* Should not override if vector was already disallowed */ It is possible a device be reconfigured between dev_stop/dev_start, vector = mode may fit for the new configure, so the old rx_vec_allowd should be igno= red,=20 Regards Qi > + if (!ad->rx_vec_allowed) > + return -1; > + > /** > * Vector mode is allowed only when number of Rx queue > * descriptor is power of 2. > -- > 2.7.4