From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CB25DA05D3 for <public@inbox.dpdk.org>; Wed, 22 May 2019 16:32:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 717324C88; Wed, 22 May 2019 16:32:58 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E0E174C80 for <dev@dpdk.org>; Wed, 22 May 2019 16:32:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 07:32:56 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 22 May 2019 07:32:55 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 07:32:55 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 07:32:55 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Wed, 22 May 2019 22:32:52 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> CC: "Ergin, Mesut A" <mesut.a.ergin@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com> Thread-Topic: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx Thread-Index: AQHVEKdqtPj3ZSaMfEm09gK4nrXNAKZ3L//g Date: Wed, 22 May 2019 14:32:52 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153385FDE@SHSMSX103.ccr.corp.intel.com> References: <1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com> <3615B82CA151CF42A86EDDD9846A8B38C7A872FE@ORSMSX112.amr.corp.intel.com> <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com> <3457411.zOjnD88UkL@xps> In-Reply-To: <3457411.zOjnD88UkL@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDI0YmY5MzktZGViYy00MWRmLTk4YTktOTQ3MGMwYzYwYzhkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWhZb2RUZVN5VDRLdklraStTMzkrR1lnVm9PZWJYTkFDXC81Q2lKdXRvWlwvaVwvRUNvZFpGMzJCMUZHdHJXbUVLQyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, May 22, 2019 10:05 PM > To: Ananyev, Konstantin <konstantin.ananyev@intel.com> > Cc: Ergin, Mesut A <mesut.a.ergin@intel.com>; Xing, Beilei > <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org= ; > Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko > <arybchenko@solarflare.com> > Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disab= le > vector rx >=20 > Hi, >=20 > 22/05/2019 13:01, Ananyev, Konstantin: > > > As far as I can see, passing FDIR configuration via the rte_eth_conf = struct: > > > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. > > > DEPRECATED */ was deprecated. I suspect in favor of the late binding > > > design mentioned, but again, I don't know the history on that. IMO, t= his > made devargs a better choice. > > > > Ok, then it looks like there is a flaw in ethdev level API that needs t= o be fixed: > > We deprecated old way to request FD usage without introducing new one. > > CC-ing to ethdev maintainers - > > Guys is there a new way to request FD enablement, instead of deprecated > fdir_config? > > Seems like not, unless I missed something obvious. > > If not, then we probably need either to re-deprecate fdir_config, or in= troduce > some new method. > > My first thought would be to add new DEV_RX_OFFLOAD_* flag(s). > > Does it make sense? >=20 > Sorry,I have not read the full thread so I may be out of topic. > Please be aware that the flow director API is deprecated in favor of the = more > generic rte_flow API. >=20 What we need is a software mark when a flow is hit, it is stored in mbuf->f= dir (there is another discussion to change the name "fdir" to a more generi= c one) For intel driver, vector rx Path does not support software mark, so current= ly we use rte_eth_conf-> rte_fdir_conf->mode to prevent vector path be sele= cted when fdir is required. actually this is not make very sense, vector path is only necessary to be d= isabled when software mark is required, but not for general fdir Now since it will be removed, it's a good chance to improve this, a new off= load flag such as DEV_RX_OFFLOAD_FLOW_MARK looks like what we needed.. Regards Qi