From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D44BAA045E for <public@inbox.dpdk.org>; Wed, 29 May 2019 19:18:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B509F1B94F; Wed, 29 May 2019 19:18:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9B2F71B948 for <dev@dpdk.org>; Wed, 29 May 2019 19:18:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 10:18:52 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 29 May 2019 10:18:51 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 10:18:51 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 10:18:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.120]) by shsmsx102.ccr.corp.intel.com ([169.254.2.134]) with mapi id 14.03.0415.000; Thu, 30 May 2019 01:18:49 +0800 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com>, David Harton <dharton@cisco.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com> Thread-Topic: [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c Thread-Index: AQHVDBUeMzFUqVPH9UCak4CH7wQ3vKZulk0AgBPWn+A= Date: Wed, 29 May 2019 17:18:49 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153391CE0@SHSMSX103.ccr.corp.intel.com> References: <20190515161346.33080-1-dharton@cisco.com> <20190516182803.11662-1-dharton@cisco.com> <20190517102127.GA660@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190517102127.GA660@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGYzMzA4YTYtNzE5Zi00OWU3LTk4MmQtZDNhMTc4N2U5MzAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaVZqTmliZzk3dDZTZzBhZWw5QzVid2NFNWVucGpyN0tMNlVvdDdSbXIzcVMzWFA5Q3ZFQVpLNnA4cTlkbnE5NiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, May 17, 2019 3:21 AM > To: David Harton <dharton@cisco.com> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com> > Subject: Re: [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c >=20 > On Thu, May 16, 2019 at 02:28:03PM -0400, David Harton wrote: > > Use of weak symbols can hide makefile errors especially when custom > > makefiles are used. Removing the use of weak symbols to avoid a stub > > function being linked in production code. > > > > Signed-off-by: David Harton <dharton@cisco.com> > > --- > > > > v3 - added CONFIG_RTE_LIBRTE_I40E_INC_VECTOR to makefile > > v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied to dpdk-next-net-intel. Thanks Qi