From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A0FA0471 for ; Tue, 16 Jul 2019 03:13:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97E752C5E; Tue, 16 Jul 2019 03:13:36 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7E40F2BE1 for ; Tue, 16 Jul 2019 03:13:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 18:13:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,496,1557212400"; d="scan'208";a="187230276" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 15 Jul 2019 18:13:34 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 15 Jul 2019 18:13:34 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 15 Jul 2019 18:13:34 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Tue, 16 Jul 2019 09:13:32 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" Thread-Topic: [PATCH] net/ice: fix item number when pattern has ETH Thread-Index: AQHVOvBkQcto8C/u20q8V0QPi3UVPKbMcLpQ Date: Tue, 16 Jul 2019 01:13:31 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D67568@SHSMSX105.ccr.corp.intel.com> References: <1563181362-29513-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1563181362-29513-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzJmYTRjNzQtMTBlZS00MWEwLTk4MWEtOTZlNTQ1ZDg2MzIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHVHM1h0K2MyUnlIT3NxYWpPSDJJOFRLcENRbkRtYVU4c0cwdHF3aWJTcFpNVTdMbDNpYTRNaXU0S1d4MGpYTiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix item number when pattern has ETH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, July 15, 2019 5:03 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/ice: fix item number when pattern has ETH >=20 > When pattern has ETH, maybe it will contain MAC and ethertype two kinds o= f > lookup parameters, so add more item number for memory malloc. >=20 > Signed-off-by: wei zhao > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 5424223..6ec50fb 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -435,6 +435,8 @@ ice_create_switch_filter(struct ice_pf *pf, > tun_type =3D ICE_SW_TUN_VXLAN; > if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_NVGRE) > tun_type =3D ICE_SW_TUN_NVGRE; > + if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_ETH) I would suggest add some comment here like=20 "reserve one more slot for ETH which may consume 2 lookup items"=20 to help others easy to understand. > + item_num++; > } > rule_info.tun_type =3D tun_type; >=20 > -- > 2.7.5