From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA515A046B for ; Tue, 23 Jul 2019 09:30:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CE7A1BFAD; Tue, 23 Jul 2019 09:30:13 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B825C1BFAC; Tue, 23 Jul 2019 09:30:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 00:30:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,298,1559545200"; d="scan'208";a="177217311" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jul 2019 00:30:09 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jul 2019 00:30:09 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 23 Jul 2019 00:30:05 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 23 Jul 2019 00:30:05 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 15:30:04 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: fix x550 Reta set fail error Thread-Index: AQHVQRFRRrYHWZnpHkajThP3+e2Mt6bXzbqg Date: Tue, 23 Jul 2019 07:30:03 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D6B6E9@SHSMSX105.ccr.corp.intel.com> References: <1563775495-13785-1-git-send-email-wei.zhao1@intel.com> <1563855198-11568-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1563855198-11568-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWNiMDFmYmEtOGZiOS00YjNlLWI1YzMtNzZkZDNkNDA0NmMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWTNLTGMxZlZ3T0Q0N3VGREVWQUVSMWlpc0tlMEVlTmswY0xydHhUR0luZjNnR05XRmxYV2xXbmplaDFWclwvb3EifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, July 23, 2019 12:13 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v2] net/ixgbe: fix x550 Reta set fail error >=20 > There is a bug in function ixgbevf_dev_info_get(), it do not contain the = reta > table size get function for vf port, and this will cause error when updat= e reta > for x550 vf port. And also when function ixgbe_reta_size_get() is called,= it > should return other ixgbe NIC vf reta support or not, not only x550. This commit log is a little bit misleading=20 Does below description OK for you? Title: net/ixgbe: fix reta size for VF Filling correct reta table size at ixgbevf_dev_info_get, so reta table upda= te will be supported for VF port. For X540_vf and 82599_vf, since they don't support reta table update, set r= eta size to 0. >=20 > Cc: stable@dpdk.org >=20 > Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info") > Signed-off-by: wei zhao > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 22c5b2c..773f667 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev, > dev_info->rx_queue_offload_capa); > dev_info->tx_queue_offload_capa =3D ixgbe_get_tx_queue_offloads(dev); > dev_info->tx_offload_capa =3D ixgbe_get_tx_port_offloads(dev); > + dev_info->hash_key_size =3D IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t); > + dev_info->reta_size =3D ixgbe_reta_size_get(hw->mac.type); >=20 > dev_info->default_rxconf =3D (struct rte_eth_rxconf) { > .rx_thresh =3D { > @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type > mac_type) { > case ixgbe_mac_X550EM_x_vf: > case ixgbe_mac_X550EM_a_vf: > return ETH_RSS_RETA_SIZE_64; > + case ixgbe_mac_X540_vf: > + case ixgbe_mac_82599_vf: > + return 0; > default: > return ETH_RSS_RETA_SIZE_128; > } > -- > 2.7.5