From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1383A046B for ; Fri, 26 Jul 2019 06:48:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E7AC1C3BA; Fri, 26 Jul 2019 06:48:22 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 446E91C3AF for ; Fri, 26 Jul 2019 06:48:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 21:48:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,309,1559545200"; d="scan'208";a="369931826" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 25 Jul 2019 21:48:18 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 21:48:18 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 25 Jul 2019 21:48:18 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.15]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Fri, 26 Jul 2019 12:48:16 +0800 From: "Zhang, Qi Z" To: "Ergin, Mesut A" , "Xing, Beilei" CC: "dev@dpdk.org" , "Van Haaren, Harry" Thread-Topic: [PATCH] net/i40e: fix flow double mark action error check Thread-Index: AQHVQzMOqojcjBVXGkGBsln2yEggN6bcVCMQ Date: Fri, 26 Jul 2019 04:48:15 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D7413E@SHSMSX105.ccr.corp.intel.com> References: <1564091449-34248-1-git-send-email-mesut.a.ergin@intel.com> In-Reply-To: <1564091449-34248-1-git-send-email-mesut.a.ergin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjM0Zjg0OGYtMzg1NS00N2QxLWFmYzItZjUxMDA2ZGQ5YTJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUUxLYXVrWVFkUWo4VUtUNVo5S0tIanJMeHd3V1RWbjF6Ukd6TE9WVm5QZHptOGlpbTY5WkNGM2hINUpYb0MxWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow double mark action error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ergin, Mesut A > Sent: Friday, July 26, 2019 5:51 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Van Haaren, Harry ; Ergin, > Mesut A > Subject: [PATCH] net/i40e: fix flow double mark action error check >=20 > This commit fixes an issue with the error checking in flow MARK action. > Previously, (ANY + MARK) would fail, as the (mark_spec =3D=3D 0) conditio= n > would cause an early error return, however really it is (mark_spec !=3D 0= ) that > should cause the early error return. >=20 > Flipping the binary comparison corrects the behaviour, and (ANY + MARK) > now succeeds, while (MARK + MARK) fails. >=20 > Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action") >=20 > Suggested-by: Harry van Haaren > Signed-off-by: Mesut Ali Ergin > --- Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi