From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1982A0613 for ; Fri, 30 Aug 2019 03:06:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97C551E53F; Fri, 30 Aug 2019 03:06:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DC2EF1E4DC for ; Fri, 30 Aug 2019 03:06:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 18:06:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,445,1559545200"; d="scan'208";a="332703056" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2019 18:06:52 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 18:06:52 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 29 Aug 2019 18:06:51 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 29 Aug 2019 18:06:51 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Fri, 30 Aug 2019 09:06:49 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Rong, Leyi" , "Ye, Xiaolong" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 6/6] net/ice: switch to Rx flexible descriptor in AVX path Thread-Index: AQHVXkCqWI6HcDOJHE66dgkVWVdbbKcSxSYQ//+WTACAAIZgsA== Date: Fri, 30 Aug 2019 01:06:49 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D867A3@SHSMSX105.ccr.corp.intel.com> References: <20190829023421.112551-2-leyi.rong@intel.com> <20190829080441.12602-1-leyi.rong@intel.com> <20190829080441.12602-7-leyi.rong@intel.com> <039ED4275CED7440929022BC67E7061153D8671C@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTY5MmM3NDYtNTBhOC00NGIwLTk0MWMtOTUxNTgyZDdlY2NhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYklVQkJra0VXQTZRZVpmRHlVXC93TTZLdnoxMU9SWmVsNDRINTBLTXp6TUlYclVCODB0ZCtoR3Ywd3lFWmtLZlYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] net/ice: switch to Rx flexible descriptor in AVX path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, August 30, 2019 9:06 AM > To: Zhang, Qi Z ; Rong, Leyi ; > Ye, Xiaolong ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 6/6] net/ice: switch to Rx flexible descriptor in = AVX > path >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, August 30, 2019 07:32 > > To: Rong, Leyi ; Ye, Xiaolong > > ; Wang, Haiyue ; Lu, > > Wenzhuo > > Cc: dev@dpdk.org > > Subject: RE: [PATCH v2 6/6] net/ice: switch to Rx flexible descriptor > > in AVX path > > > > > > > > > -----Original Message----- > > > From: Rong, Leyi > > > Sent: Thursday, August 29, 2019 4:05 PM > > > To: Zhang, Qi Z ; Ye, Xiaolong > > > ; Wang, Haiyue ; Lu, > > > Wenzhuo > > > Cc: dev@dpdk.org; Rong, Leyi > > > Subject: [PATCH v2 6/6] net/ice: switch to Rx flexible descriptor in > > > AVX path > > > > > > Switch to Rx flexible descriptor format instead of legacy descriptor > format. > > > > > > Signed-off-by: Leyi Rong > > > --- > > > drivers/net/ice/ice_rxtx_vec_avx2.c | 232 > > > ++++++++++++++-------------- > > > 1 file changed, 118 insertions(+), 114 deletions(-) > > > > > > diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c > > > b/drivers/net/ice/ice_rxtx_vec_avx2.c > > > index 5ce29c2a2..158f17d80 100644 > > > --- a/drivers/net/ice/ice_rxtx_vec_avx2.c > > > +++ b/drivers/net/ice/ice_rxtx_vec_avx2.c > > > @@ -15,10 +15,10 @@ ice_rxq_rearm(struct ice_rx_queue *rxq) { > > > int i; > > > uint16_t rx_id; > > > - volatile union ice_rx_desc *rxdp; > > > + volatile union ice_rx_flex_desc *rxdp; > > > struct ice_rx_entry *rxep =3D &rxq->sw_ring[rxq->rxrearm_start]; > > > > > > - rxdp =3D rxq->rx_ring + rxq->rxrearm_start; > > > + rxdp =3D (union ice_rx_flex_desc *)rxq->rx_ring + > > > +rxq->rxrearm_start; > > > > Since after this patch, all data paths (normal, sse, avx2) are moved > > to flex desc, Ice_rx_desc is not used anymore, so can replace all of > > them with ice_rx_flex_desc, then above convention can be avoid. > > >=20 > I think we can submit another minimal patch set to clean up ice_rx_desc a= nd > fix this kind of convention. Since for developing in parallel, Reyi and I= have to > use this kind of convention. :) +1=20 >=20 > > <.......> > > > > > * take the two sets of status bits and merge to one @@ > -450,20 > > > > > > > > /* merge flags */ > > > const __m256i mbuf_flags =3D _mm256_or_si256(l3_l4_flags, > > > -- > > > 2.17.1