From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0804A2EFC for ; Tue, 17 Sep 2019 04:40:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F9B41BFE4; Tue, 17 Sep 2019 04:40:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 326F01BFBF; Tue, 17 Sep 2019 04:40:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 19:40:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,515,1559545200"; d="scan'208";a="361716148" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 16 Sep 2019 19:40:32 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 19:40:32 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 19:40:31 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 10:40:29 +0800 From: "Zhang, Qi Z" To: Thierry Herbelot , "dev@dpdk.org" CC: Laurent Hardy , Thomas Monjalon , "stable@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH] net/i40e: set speed to undefined for default case in link update Thread-Index: AQHVaLpmH0mqFmeOhk2maPTZB9xniacvMPTQ Date: Tue, 17 Sep 2019 02:40:29 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D97B01@SHSMSX105.ccr.corp.intel.com> References: <2121840c6dc59bcd1caffa8f4c8428fed5d667a7.1568216789.git.thierry.herbelot@6wind.com> In-Reply-To: <2121840c6dc59bcd1caffa8f4c8428fed5d667a7.1568216789.git.thierry.herbelot@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjU1MDJlOWUtOGZjNC00ZjU4LWE4N2UtMjBjMGZmNWQ0NTdjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYlQ3Rk5xOXlHakVoNWN5S3NSNGJhc0Y3dHFIUDVyVlhheE9uQWwrVFVuOEJXZzU3NDl4Ym5EcUhqYUptaFc3byJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: set speed to undefined for default case in link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thierry Herbelot [mailto:thierry.herbelot@6wind.com] > Sent: Thursday, September 12, 2019 12:03 AM > To: dev@dpdk.org > Cc: Laurent Hardy ; Thomas Monjalon > ; stable@dpdk.org; Xing, Beilei > ; Zhang, Qi Z > Subject: [PATCH] net/i40e: set speed to undefined for default case in lin= k > update >=20 > From: Laurent Hardy >=20 > During PF/VF link update, a default speed value of 100M will be set if > get_link_info has failed or speed is unknown. >=20 > Consequently if PF is put in no-carrier state, VFs will switch to "in car= rier" state > due to a link up + a link speed set to 100M (default value if no speed de= tected). >=20 > To be consistent with linux drivers on which PF and VFs are in same carri= er > state, sets default speed to undefined (instead of 100M) and updates a li= nk > status of VF only if link is up and speed is different from undefined. >=20 > Fixes: 4861cde46116 ('i40e: new poll mode driver') > Cc: stable@dpdk.org > Cc: beilei.xing@intel.com > Cc: qi.z.zhang@intel.com >=20 > Signed-off-by: Laurent Hardy Acked-by: Qi Zhang