From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDEE2A0613 for ; Fri, 27 Sep 2019 08:19:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 067A42BE5; Fri, 27 Sep 2019 08:19:03 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 00B521DB9 for ; Fri, 27 Sep 2019 08:19:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 23:18:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,554,1559545200"; d="scan'208";a="201913990" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 26 Sep 2019 23:18:59 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 23:18:58 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 23:18:58 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.23]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 14:18:56 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Nowlin, Dan" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule Thread-Index: AQHVdOn+yslR25tXLUek+/e6WfcEIqc+eYYAgACTS7A= Date: Fri, 27 Sep 2019 06:18:54 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D9EDF1@SHSMSX105.ccr.corp.intel.com> References: <20190902035551.16852-1-qi.z.zhang@intel.com> <20190927041646.34712-1-qi.z.zhang@intel.com> <20190927041646.34712-2-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODkzNDc5MzYtNTM4Zi00YTZlLTk4OTktMTUzMGJjZjM3OThiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOVlGdEx3aFZtTEk4YWNOcU0yMllPbEdMQW9hM1VEc1ZuVnhEU0JHMUJZaW5LbFQ3aCs1U0lXejBzK3BYMEJWNCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Qiming > Sent: Friday, September 27, 2019 1:31 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org; Ye, Xiaolong ; Nowlin, Dan > ; Stillwell Jr, Paul M > Subject: RE: [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule >=20 > Missing CC stable for the fix patches. This fix on the patch from current release, no need to CC stable >=20 > Qiming >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, September 27, 2019 12:17 PM > > To: Lu, Wenzhuo ; Yang, Qiming > > > > Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > ; Nowlin, Dan ; Stillwell > > Jr, Paul M > > Subject: [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule > > > > Update VLAN protocol ID to correct value for single VXLAN scenario. > > Correct the PPPOE training packet. > > > > Fixes: d341bdc30290 ("net/ice/base: add support for GTP and PPPoE > > protocols") > > > > Signed-off-by: Dan Nowlin > > Signed-off-by: Paul M Stillwell Jr > > Signed-off-by: Qi Zhang > > --- > > drivers/net/ice/base/ice_protocol_type.h | 2 +- > > drivers/net/ice/base/ice_switch.c | 12 +++++++----- > > 2 files changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ice/base/ice_protocol_type.h > > b/drivers/net/ice/base/ice_protocol_type.h > > index f61345a7f..548c9730a 100644 > > --- a/drivers/net/ice/base/ice_protocol_type.h > > +++ b/drivers/net/ice/base/ice_protocol_type.h > > @@ -118,7 +118,7 @@ enum ice_prot_id { > > #define ICE_MAC_OFOS_HW 1 > > #define ICE_MAC_IL_HW 4 > > #define ICE_ETYPE_OL_HW 9 > > -#define ICE_VLAN_OL_HW 16 > > +#define ICE_VLAN_OL_HW 17 > > #define ICE_IPV4_OFOS_HW 32 > > #define ICE_IPV4_IL_HW 33 > > #define ICE_IPV6_OFOS_HW 40 > > diff --git a/drivers/net/ice/base/ice_switch.c > > b/drivers/net/ice/base/ice_switch.c > > index 80afa74cd..a72f4b430 100644 > > --- a/drivers/net/ice/base/ice_switch.c > > +++ b/drivers/net/ice/base/ice_switch.c > > @@ -433,16 +433,18 @@ dummy_pppoe_packet[] =3D { > > > > 0x00, 0x00, 0x88, 0x64, /* ICE_VLAN_OFOS 14 */ > > > > - 0x11, 0x00, 0x00, 0x01, /* ICE_PPPOE 18 */ > > - 0x00, 0x4e, 0x00, 0x21, > > + 0x11, 0x00, 0x00, 0x00, /* ICE_PPPOE 18 */ > > + 0x00, 0x16, > > > > - 0x45, 0x00, 0x00, 0x30, /* PDU */ > > + 0x00, 0x21, /* PPP Link Layer 24 */ > > + > > + 0x45, 0x00, 0x00, 0x14, /* ICE_IPV4_IL 26 */ > > + 0x00, 0x00, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, > > - 0x00, 0x11, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, > > > > - 0x00, 0x00, /* 2 bytes for 4 byte alignment */ > > + 0x00, 0x00, /* 2 bytes for 4 bytes alignment */ > > }; > > > > /* this is a recipe to profile association bitmap */ > > -- > > 2.13.6