From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D465EA04B8; Tue, 12 Nov 2019 08:50:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 233122BEA; Tue, 12 Nov 2019 08:50:43 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 16A0B235 for ; Tue, 12 Nov 2019 08:50:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 23:50:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="287466333" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 11 Nov 2019 23:50:39 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 23:50:39 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 23:50:39 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.225]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 15:50:37 +0800 From: "Zhang, Qi Z" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Xing, Beilei" , "Wang, ShougangX" Thread-Topic: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile Thread-Index: AQHVmShVCqiLmhqcA0ah+Ns3VkzK/KeHKArg Date: Tue, 12 Nov 2019 07:50:36 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153DC82FF@SHSMSX105.ccr.corp.intel.com> References: <20191107022217.41046-1-shougangx.wang@intel.com> <20191112005056.30805-1-shougangx.wang@intel.com> <20191112005056.30805-3-shougangx.wang@intel.com> In-Reply-To: <20191112005056.30805-3-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmY0MWE3NjMtYWEzOC00YzNlLThlYjgtMzAyNzAzOTRkNWFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUkRoeHhiTnZncVpNR0pnaG1vTU0rTTNjaUt2b281eVRkZGZPSGh5SXgrbnUzK3pob1RcLzdJT2JLUlVMVUVRVUwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wang ShougangX > Sent: Tuesday, November 12, 2019 8:51 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Wang, ShougangX > Subject: [dpdk-dev] [PATCH v3 2/4] net/ice: fix removal of FDIR profile >=20 > The removal of FDIR profile should start from > ICE_FLTR_PTYPE_NONF_IPV4_UDP. >=20 > Fixes: 109e8e06249e ("net/ice: configure HW flow director rule") >=20 > Signed-off-by: Wang ShougangX > --- > drivers/net/ice/ice_fdir_filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index a89c506c0..f728b9062 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -571,7 +571,7 @@ ice_fdir_prof_rm_all(struct ice_pf *pf) { > enum ice_fltr_ptype ptype; >=20 > - for (ptype =3D ICE_FLTR_PTYPE_NONF_NONE; > + for (ptype =3D ICE_FLTR_PTYPE_NONF_IPV4_UDP; Is "ptype =3D ICE_FLTR_PTYPE_NONF_NONE + 1" better?, so we don't need to wo= rry profile be re-ordered or new one be inserted in future. > ptype < ICE_FLTR_PTYPE_MAX; > ptype++) { > ice_fdir_prof_rm(pf, ptype, false); > -- > 2.17.1