From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4A60A04C2; Thu, 14 Nov 2019 05:52:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BC3F2BAE; Thu, 14 Nov 2019 05:52:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1AD4A2BA8 for ; Thu, 14 Nov 2019 05:52:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2019 20:52:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,302,1569308400"; d="scan'208";a="288103609" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 13 Nov 2019 20:52:46 -0800 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 20:52:46 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 20:52:46 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.225]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Thu, 14 Nov 2019 12:52:44 +0800 From: "Zhang, Qi Z" To: "Su, Simei" , "Yang, Qiming" CC: "dev@dpdk.org" , "Ye, Xiaolong" Thread-Topic: [PATCH v2] net/ice: fix flow destroy issue for RSS Thread-Index: AQHVmcau9P0HRkZEA0e1wgZdYClDbKeKGwcg Date: Thu, 14 Nov 2019 04:52:43 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153DC9335@SHSMSX105.ccr.corp.intel.com> References: <1573546349-341486-1-git-send-email-simei.su@intel.com> <1573610609-175412-1-git-send-email-simei.su@intel.com> In-Reply-To: <1573610609-175412-1-git-send-email-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IxODI5YzItOTliMS00OWNmLTg0MjgtMzgzYjNmMjg2NmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV3J3elwvZ2Nnck5VcFpVeVdrRWg4TEtYcXNSV2s1RlZ2K0VpbnpqZXhsckg4Y3UwVkFrMlwvVEkzM0pqUTk5TUFiIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix flow destroy issue for RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Su, Simei > Sent: Wednesday, November 13, 2019 10:03 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Ye, Xiaolong ; Su, Simei > > Subject: [PATCH v2] net/ice: fix flow destroy issue for RSS >=20 > In ice_hash_create(), whatever the hash_function is, the filter_ptr->symm= is > always 0 and when we destroy the flow, the ice_rem_rss_cfg() is never car= ried > out. So the destroy function never works well. The patch fixes this issue= and at > the same time distinguishes semanteme between simple_xor and > symmetric_toeplitz. >=20 > To fix this issue, the patch adds a new structure to include a flag to in= dicate if it > is a simple_xor flow so that it's easier to remove the config when destro= ying > the flow. The patch also simplifies code implementation logic in > ice_hash_create(). >=20 > Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >=20 > Signed-off-by: Simei Su Acked-by: Qi Zhang