From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 714F1A04C7; Thu, 21 Nov 2019 02:20:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4457127D; Thu, 21 Nov 2019 02:20:08 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5A8D4271 for ; Thu, 21 Nov 2019 02:20:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 17:20:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="218893943" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 20 Nov 2019 17:20:03 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 17:20:03 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 17:20:02 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.225]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 09:20:01 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "orika@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support Thread-Index: AQHVnqBEvrWfRlZogEKSmQzsdRLUU6eT5RmAgADbnNA= Date: Thu, 21 Nov 2019 01:19:59 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153DCE1E6@SHSMSX105.ccr.corp.intel.com> References: <20191119061442.21369-1-qi.z.zhang@intel.com> <2166340.TqaS7Hc55D@xps> In-Reply-To: <2166340.TqaS7Hc55D@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTFmZWJkYzgtZWNjOC00YzlhLTk2MTgtMTFiZDE4N2VmMzczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia3Z5MmZxakhORHc3QnFGeEJ1VG1yVnJuXC9BciszaXpGZ01PVTZwRndpK3RJcjBKeHN5NUhJRGwzVkdMYnRFNGoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, November 21, 2019 2:57 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Yigit, Ferruh > ; arybchenko@solarflare.com; orika@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support >=20 > 19/11/2019 07:14, Qi Zhang: > > Since not all data paths support flow mark, the driver needs a hint > > from application to select the correct data path if flow mark is > > required. The patch introduces a devarg "flow-mark-support" as a > > workaround solution, since a standard way is still ongoing. > > > > Signed-off-by: Qi Zhang > > Acked-by: Qiming Yang > > --- > > > > v4: > > - remove debug code, fix typos > > > > v3: > > - add "experimental notification" in ice.rst > > > > v2: > > - fix typos >=20 > Please use --in-reply-to to help tracking all the versions together. >=20 > > +- ``Flow Mark Support`` (default ``0``) > > + > > + This is a hint to the driver to select the data path that supports > > + flow mark extraction by default. > > + NOTE: This is an experimental devarg, it will be removed when any > > + of below conditions is ready. > > + 1) all data paths support flow mark (currently vPMD does not) > > + 2) a new offload like RTE_DEV_RX_OFFLOAD_FLOW_MARK be introduced > as a standard way to hint. >=20 > When the data path is selected? dev_start > I suppose such decision should be done when starting the port, after ever= ything > is configured. > So you can check if a rte_flow rule was added for mark action. > Why the user needs to use an explicit option? A rte_flow with mark can be issued at any time after dev_start when it is n= eed, in that case, we have to reject the flow, this has been complained a l= ot base on previous feedback by users, since inconsistent behavior (sometim= es mark works, some time it does not) is not expected Also this option is overwhelmed by option 1 if we plan to do a clean fix in= driver. >=20