From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80A99A04F1; Mon, 9 Dec 2019 00:51:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BADFD374E; Mon, 9 Dec 2019 00:51:27 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 197F53576; Mon, 9 Dec 2019 00:51:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2019 15:51:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,293,1571727600"; d="scan'208";a="412580451" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 08 Dec 2019 15:51:22 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 15:51:22 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 15:51:22 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.72]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.71]) with mapi id 14.03.0439.000; Mon, 9 Dec 2019 07:51:20 +0800 From: "Zhang, Qi Z" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix flow control broken Thread-Index: AQHVrAol/OawzMRLlE24XrRI/mujcaew69tw Date: Sun, 8 Dec 2019 23:51:19 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153DDE1C3@SHSMSX105.ccr.corp.intel.com> References: <20191206154118.4401-1-guinanx.sun@intel.com> In-Reply-To: <20191206154118.4401-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGM1NWE1NTYtOThiZS00NjJlLThmOTQtN2I4ZGE5NWJkYmVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidW4yYndibDVnYTFreHNVZWNVTWRZN3BaYUJWQ0dCcFVUblZjNDdlZTdEbFZKdFNrTXhPQlM5V1FveXBIXC9RdnUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow control broken X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sun, GuinanX > Sent: Friday, December 6, 2019 11:41 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Yang, Qiming ; Sun, GuinanX > ; stable@dpdk.org > Subject: [PATCH] net/i40e: fix flow control broken >=20 > Repeat switching flow control on or off during receiving traffic, testpmd= reports > "failed to switch Tx queue occurs" after quit. > The patch fixes the issue. The explain more about the root cause and the fix. >=20 > Fixes: f53577f06925 ("i40e: support flow control") > Cc: stable@dpdk.org >=20 > Signed-off-by: Guinan Sun > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 5999c964b..5507f6c39 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -53,7 +53,7 @@ >=20 > /* Wait count and interval */ > #define I40E_CHK_Q_ENA_COUNT 1000 > -#define I40E_CHK_Q_ENA_INTERVAL_US 1000 > +#define I40E_CHK_Q_ENA_INTERVAL_US 50000 >=20 > /* Maximun number of VSI */ > #define I40E_MAX_NUM_VSIS (384UL) > -- > 2.17.1