From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FF2EA046B; Thu, 9 Jan 2020 13:44:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAC711DA10; Thu, 9 Jan 2020 13:44:24 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 28C3F1D721 for ; Thu, 9 Jan 2020 13:44:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 04:44:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="303858222" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 09 Jan 2020 04:44:21 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 04:44:21 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Jan 2020 04:44:20 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Jan 2020 04:44:20 -0800 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.28]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Thu, 9 Jan 2020 20:44:18 +0800 From: "Zhang, Qi Z" To: "Iremonger, Bernard" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Ananyev, Konstantin" , "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 6/9] net/i40e: display Flow Director packet Thread-Index: AQHVxua5z3tfvMGFLESuShT1XlQot6fiRoBw Date: Thu, 9 Jan 2020 12:44:17 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard: > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:17 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 6/9] net/i40e: display Flow Director packet >=20 > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c >=20 > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_fdir.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > 3fa6297..78329d2 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include >=20 > #include "i40e_logs.h" > #include "base/i40e_type.h" > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > rte_eth_fdir_input *fdir_input, > fdir_input->flow_type); > return -1; > } > + rte_hexdump(stdout, NULL, raw_pkt, len); Why we need this? Does this just for debug? Regards Qi > return len; > } >=20 > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > &fdir_input->flow_ext.flexbytes[dst], > size * sizeof(uint16_t)); > } > - > + rte_hexdump(stdout, NULL, raw_pkt, len); > return 0; > } >=20 > -- > 2.7.4