From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B723A0583; Fri, 20 Mar 2020 12:16:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 569132BB9; Fri, 20 Mar 2020 12:16:06 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E7E9C3B5 for ; Fri, 20 Mar 2020 12:16:04 +0100 (CET) IronPort-SDR: /cCvT9xpxq5Ix8TX0OqkjuxkjYkbo3OxcocmzbTpREXr7kSHir4HYR14J4lgVkfYIbmDuyJj9o g1lDjepnxI8Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2020 04:16:03 -0700 IronPort-SDR: AH21zvk6c4o/nB+lflQ8RaXMRrg1q/CnzgpGnJr5TQ74uz4j3yIpMIHZGt9uqNqMGbJbWSaQ/0 VtqBK+En201w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,284,1580803200"; d="scan'208";a="239199943" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 20 Mar 2020 04:16:03 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Mar 2020 04:16:02 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 20 Mar 2020 04:16:02 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 20 Mar 2020 04:16:02 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.137]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Fri, 20 Mar 2020 19:15:59 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , "rahul.lakkireddy@chelsio.com" , "Wang, Xiao W" , "xavier.huwei@huawei.com" , "Xing, Beilei" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "jerinj@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" Thread-Topic: [PATCH 0/3] refresh NIC features matrix Thread-Index: AQHV9/kTpUL0ShYpnECecwcPtDPVJ6hQ/IFQ///WooCAAIsD4A== Date: Fri, 20 Mar 2020 11:15:58 +0000 Message-ID: <039ED4275CED7440929022BC67E70611547E55AD@SHSMSX103.ccr.corp.intel.com> References: <20200311230136.63452-1-thomas@monjalon.net> <039ED4275CED7440929022BC67E70611547E53BE@SHSMSX103.ccr.corp.intel.com> <5581955.lOV4Wx5bFT@xps> In-Reply-To: <5581955.lOV4Wx5bFT@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, March 20, 2020 6:45 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; rahul.lakkireddy@chelsio.com; Wang, Xiao W > ; xavier.huwei@huawei.com; Xing, Beilei > ; Lu, Wenzhuo ; Yang, Qiming > ; Ananyev, Konstantin > ; Yigit, Ferruh ; > jerinj@marvell.com; rmody@marvell.com; shshaikh@marvell.com; > maxime.coquelin@redhat.com; Ye, Xiaolong > Subject: Re: [PATCH 0/3] refresh NIC features matrix >=20 > 20/03/2020 06:35, Zhang, Qi Z: > > Hi Thomas: > > > > From: Thomas Monjalon > > > > > > This series aims to clean-up the big table of ethdev features: > > > http://doc.dpdk.org/guides/nics/overview.html#id1 > > > > > > We could reorganize the information in this table, maybe split it or > > > add/remove some rows. > > > Before going to such reorganization, we should clean it up. > > > > > > The first patch is fixing the look & size of the table with recent sp= hinx. > > > > > > The second and third patches are removing 8 columns which are > > > clearly > > > unneeded: > > > - bnx2x_vf > > > - bonding > > > - kni > > > - nfp_vf > > > - null > > > - ring > > > - softnic > > > - vdev_netvsc > > > > > > More columns can be removed by merging PF/VF and vector datapaths. > > > If a feature cannot be supported in all cases, it should be marked > > > as partially supported (P). > > > If a feature is PF-specific (like flow control), that's OK to mark > > > it fully supported because it's obviously impossible for VF. > > > There are also some features which were probably marked in some > > > columns and missed in its VF or vector counterpart. > > > Please work to merge and drop these 16 columns: > > > - cxgbevf > > > - fm10k_vf > > > - hns3_vf > > > - i40e_vec > > > - i40e_vf > > > - i40e_vf_vec > > > - iavf_vec > > > - ice_vec > > > - igb_vf > > > - ixgbe_vec > > > - ixgbe_vf > > > - ixgbe_vf_vec > > > - octeontx2_vec > > > - octeontx2_vf > > > - qede_vf > > > - virtio_vec > > > > > > The total gain is to reduce the table size from 71 to 47 columns. > > > > I agree to remove all the column with "vec", since vector PMD can be > regarded as a feature of the a PMD. > > But I'm not sure if it is a good idea to merge VF and PF into one colum= n. > > From my view, for intel device, VF driver and PF driver just share the = code, > but they actually are running at two different context. > > And likely they will support different feature, merge into one column m= ay > confuse our customer if they want to understand what exactly the PMD > support. >=20 > I understand you have 2 different datapaths. > My arguments are: > - it is the same NIC Yes, but one device can be polymorphic, ideally i40e and i40evf could be in= two different folder, and the common part can be a library in driver/commo= n/i40e. > - you cannot summarize everything in a table > - we have two many columns to make it readable I don't think columns number is critical, typically user just need to focus= on the first column and the specific driver's column,=20 I guess it may not a big challenge to enable some filter by front end web t= echnique? >=20 > I think the right solution is mark features as partially available (P), a= nd give > details in the driver guide documentation. >=20 > Can you please, at least, remove the "vec" columns, as a first step? Sure, as I said, I agree to remove "vec". Thanks Qi > Thanks >=20