From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37514A0577; Wed, 15 Apr 2020 04:31:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABC021D183; Wed, 15 Apr 2020 04:31:45 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A156E1D178 for ; Wed, 15 Apr 2020 04:31:44 +0200 (CEST) IronPort-SDR: ZTusObeG2hqGkwQ1ajp38muOW5RliMuyKpZSnCG58DFvSTPwv0ZOOYd1/J4seeJUxcAEtFCJtL FnUeeo139UhA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 19:31:43 -0700 IronPort-SDR: +x+DXggfkIUxamuy3ul0cRi1cwg6LM651nyH/f1KYimhJN6FQFecZwa//l9LmMKsXdEik0wSLX 6zR40c8PWNUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,385,1580803200"; d="scan'208";a="242178668" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 14 Apr 2020 19:31:43 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 19:31:43 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 19:31:42 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.146]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.89]) with mapi id 14.03.0439.000; Wed, 15 Apr 2020 10:31:40 +0800 From: "Zhang, Qi Z" To: Ori Kam , "Guo, Jia" , "Iremonger, Bernard" , "Ye, Xiaolong" CC: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" Thread-Topic: [dpdk-dev v4 1/3] ethdev: add new RSS offload types Thread-Index: AQHWEjkzcdy9Kpi7TEu/1bMFHRW04Kh314OAgAGffiA= Date: Wed, 15 Apr 2020 02:31:39 +0000 Message-ID: <039ED4275CED7440929022BC67E70611547F9991@SHSMSX103.ccr.corp.intel.com> References: <20200318170401.7938-5-jia.guo@intel.com> <20200414174225.64120-1-jia.guo@intel.com> <20200414174225.64120-2-jia.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam > Sent: Tuesday, April 14, 2020 5:43 PM > To: Guo, Jia ; Iremonger, Bernard > ; Ye, Xiaolong ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui > ; Su, Simei > Subject: RE: [dpdk-dev v4 1/3] ethdev: add new RSS offload types >=20 > Hi Jeff, > PSB >=20 > Best, > Ori > > -----Original Message----- > > From: Jeff Guo > > Sent: Tuesday, April 14, 2020 8:42 PM > > To: Ori Kam ; bernard.iremonger@intel.com; > > xiaolong.ye@intel.com; qi.z.zhang@intel.com > > Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com; > > simei.su@intel.com; jia.guo@intel.com > > Subject: [dpdk-dev v4 1/3] ethdev: add new RSS offload types > > > > Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ > > ESP/AH/PFCP. > > > > Signed-off-by: Jeff Guo > > Reviewed-by: Qi Zhang > > --- > > v4->v3: > > no change > > --- > > lib/librte_ethdev/rte_ethdev.h | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.h > > b/lib/librte_ethdev/rte_ethdev.h index d1a593ad1..efe705ff0 100644 > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > @@ -511,6 +511,13 @@ struct rte_eth_rss_conf { > > #define ETH_RSS_GENEVE (1ULL << 20) > > #define ETH_RSS_NVGRE (1ULL << 21) > > #define ETH_RSS_GTPU (1ULL << 23) > > +#define ETH_RSS_ETH (1ULL << 24) > > +#define ETH_RSS_S_VLAN (1ULL << 25) > > +#define ETH_RSS_C_VLAN (1ULL << 26) > > +#define ETH_RSS_ESP (1ULL << 27) > > +#define ETH_RSS_AH (1ULL << 28) > > +#define ETH_RSS_L2TPV3 (1ULL << 29) > > +#define ETH_RSS_PFCP (1ULL << 30) > > > > /* > > * We use the following macros to combine with above ETH_RSS_* for > @@ > > -524,7 +531,9 @@ struct rte_eth_rss_conf { > > #define ETH_RSS_L3_SRC_ONLY (1ULL << 63) > > #define ETH_RSS_L3_DST_ONLY (1ULL << 62) > > #define ETH_RSS_L4_SRC_ONLY (1ULL << 61) > > -#define ETH_RSS_L4_DST_ONLY (1ULL << 60) > > +#define ETH_RSS_L4_DST_ONLY (1ULL << 60) > > +#define ETH_RSS_ETH_SRC_ONLY (1ULL << 59) > > +#define ETH_RSS_ETH_DST_ONLY (1ULL << 58) > > > Why not change to L2_RSS_SRC_ONLY? Same for DST? > Also if it is not ABI/API change I would suggest to move the ETH defines = to be > 63. I think reorder will break Application which already use 19.11. >=20 > > /** > > * For input set change of hash filter, if SRC_ONLY and DST_ONLY of > > -- > > 2.20.1