From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Ye, Xiaolong" <xiaolong.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue
Date: Wed, 13 May 2020 02:17:23 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611548151FE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <87415d09-5743-07b8-00e0-bc28e298be4b@intel.com>
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Wednesday, May 13, 2020 7:20 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue
>
> hi, qi
>
> On 5/12/2020 10:21 AM, Zhang, Qi Z wrote:
> >
> >> -----Original Message-----
> >> From: Zhang, Qi Z
> >> Sent: Tuesday, May 12, 2020 10:18 AM
> >> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei
> >> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> >> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org
> >> Subject: RE: [dpdk-dev] net/iavf: fix rss algorithm configure issue
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Guo, Jia <jia.guo@intel.com>
> >>> Sent: Sunday, May 10, 2020 4:28 AM
> >>> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> >>> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> >>> Cc: Ye, Xiaolong <xiaolong.ye@intel.com>; dev@dpdk.org; Guo, Jia
> >>> <jia.guo@intel.com>
> >>> Subject: [dpdk-dev] net/iavf: fix rss algorithm configure issue
> >>>
> >>> When configure rss rule, the etherdev rss hash function type should
> >>> be mapped to the corresponding virtchnl rss algorithm type.
> >>>
> >>> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
> >>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> >>> ---
> >>> drivers/net/iavf/iavf_hash.c | 20 +++++++++++---------
> >>> 1 file changed, 11 insertions(+), 9 deletions(-)
> >>>
> >>> diff --git a/drivers/net/iavf/iavf_hash.c
> >>> b/drivers/net/iavf/iavf_hash.c index 6359ead76..173b7633f 100644
> >>> --- a/drivers/net/iavf/iavf_hash.c
> >>> +++ b/drivers/net/iavf/iavf_hash.c
> >>> @@ -47,7 +47,7 @@ struct iavf_hash_match_type {
> >>>
> >>> struct iavf_rss_meta {
> >>> struct virtchnl_proto_hdrs *proto_hdrs;
> >>> - uint32_t hash_function;
> >>> + enum virtchnl_rss_algorithm rss_algorithm;
> >>> };
> >>>
> >>> struct iavf_hash_flow_cfg {
> >>> @@ -1001,13 +1001,15 @@ iavf_hash_parse_action(struct
> >>> iavf_pattern_match_item *pattern_match_item,
> >>>
> >>> /* Check hash function and save it to rss_meta. */
> >>> if (rss->func ==
> RTE_ETH_HASH_FUNCTION_SIMPLE_XOR)
> >>> - rss_meta->hash_function =
> >>> - RTE_ETH_HASH_FUNCTION_SIMPLE_XOR;
> >>> -
> >>> - if (rss->func ==
> >>> - RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
> >>> - rss_meta->hash_function =
> >>> - RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ;
> >>> + rss_meta->rss_algorithm =
> >>> + VIRTCHNL_RSS_ALG_R_ASYMMETRIC;
> >> RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ -->
> >> VIRTCHNL_RSS_ALG_R_ASYMMETRIC
> > A typo, it is
> > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR -->
> VIRTCHNL_RSS_ALG_R_ASYMMETRIC which looks not correct.
> >> Is it should be VIRTCHNL_RSS_ALG_XOR_SYMMETRIC?
> >>
> >>
>
> At currently driver, VIRTCHNL_RSS_ALG_R_ASYMMETRIC is used to
> identify simple XOR.
I didn't get it..
After apply your patch, we have below code which does not make sense,
/* Check hash function and save it to rss_meta. */
if (rss->func == RTE_ETH_HASH_FUNCTION_SIMPLE_XOR)
rss_meta->rss_algorithm =
VIRTCHNL_RSS_ALG_R_ASYMMETRIC;
else if...
ASYMMETRIC is not kind of symmetric hash and should not be mapped to simple xor.
>
>
> >>> + else if (rss->func ==
> >>> +
> RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
> >>> + rss_meta->rss_algorithm =
> >>> + VIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC;
> >>> + else
> >>> + rss_meta->rss_algorithm =
> >>> + VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC;
> >>>
> >>> type_match_item =
> >>> rte_zmalloc("iavf_type_match_item",
> >>> @@ -1126,7 +1128,7 @@ iavf_hash_create(__rte_unused struct
> >>> iavf_adapter *ad,
> >>> }
> >>>
> >>> rss_cfg->proto_hdrs = *rss_meta->proto_hdrs;
> >>> - rss_cfg->rss_algorithm = rss_meta->hash_function;
> >>> + rss_cfg->rss_algorithm = rss_meta->rss_algorithm;
> >>>
> >>> ret = iavf_add_del_rss_cfg(ad, rss_cfg, true);
> >>> if (!ret) {
> >>> --
> >>> 2.20.1
next prev parent reply other threads:[~2020-05-13 2:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 20:27 Jeff Guo
2020-05-12 2:17 ` Zhang, Qi Z
2020-05-12 2:21 ` Zhang, Qi Z
2020-05-12 23:20 ` Jeff Guo
2020-05-13 2:17 ` Zhang, Qi Z [this message]
2020-05-13 3:12 ` Jeff Guo
2020-05-13 20:21 ` [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type Jeff Guo
2020-05-13 20:21 ` [dpdk-dev] [dpdk-dev v2 2/2] net/iavf: fix rss algorithm configure issue Jeff Guo
2020-05-13 9:34 ` Zhang, Qi Z
2020-05-14 6:02 ` Ye Xiaolong
2020-05-14 5:59 ` [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type Ye Xiaolong
2020-05-14 6:02 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611548151FE@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).