From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A67BCA0350; Wed, 1 Jul 2020 15:28:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA90F1C2F6; Wed, 1 Jul 2020 15:28:27 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 891671BFFE for ; Wed, 1 Jul 2020 15:28:26 +0200 (CEST) IronPort-SDR: WkZDdqNyBGTZurMWYh/HwYFQ1XPWsDQJtx+4WdzxQw7lzal12I1p+6Ix+jKQRybOH26pSGVc4d pg/vVomJD8Lg== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="134029736" X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="134029736" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 06:28:25 -0700 IronPort-SDR: 6D8z7bQ6VgEGLNimAO/CdctgsJsBC7hKZ2MAf94HpARX2QX3MVd8JYrtYMVZFFEOLJrTgOziYl sRY90FbAulvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="312690144" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 01 Jul 2020 06:28:25 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 06:28:25 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 06:28:24 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.89]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.174]) with mapi id 14.03.0439.000; Wed, 1 Jul 2020 21:28:21 +0800 From: "Zhang, Qi Z" To: "Su, Simei" , "Ye, Xiaolong" , "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Jia" , "Guo, Junfeng" Thread-Topic: [PATCH 1/3] ethdev: add new RSS offload types Thread-Index: AQHWQGCOUqLL476BuUq3VK8UEBCJ/6jy1Fug Date: Wed, 1 Jul 2020 13:28:21 +0000 Message-ID: <039ED4275CED7440929022BC67E7061154849DE3@SHSMSX103.ccr.corp.intel.com> References: <1591928407-314618-1-git-send-email-simei.su@intel.com> <1591928407-314618-2-git-send-email-simei.su@intel.com> In-Reply-To: <1591928407-314618-2-git-send-email-simei.su@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Su, Simei > Sent: Friday, June 12, 2020 10:20 AM > To: Zhang, Qi Z ; Ye, Xiaolong > ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei > Subject: [PATCH 1/3] ethdev: add new RSS offload types >=20 > This patch defines new RSS offload types for PPPoE and session id is assu= med > to be the default RSS input set. Not sure if it is necessary to force the default RSS input set as session i= d for PPPoE,=20 So maybe reword to below: Typically Session Id would be the RSS input set for a PPPoE packet, but as = a hint each driver may have different default behavior >=20 > Signed-off-by: Simei Su > --- > lib/librte_ethdev/rte_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index a49242b..631b146 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -521,7 +521,7 @@ struct rte_eth_rss_conf { > #define ETH_RSS_AH (1ULL << 28) > #define ETH_RSS_L2TPV3 (1ULL << 29) > #define ETH_RSS_PFCP (1ULL << 30) > - > +#define ETH_RSS_PPPOE (1ULL << 31) >=20 > /* > * We use the following macros to combine with above ETH_RSS_* for > -- > 1.8.3.1