* [dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow
@ 2020-07-06 9:37 Shougang Wang
2020-07-07 0:38 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Shougang Wang @ 2020-07-06 9:37 UTC (permalink / raw)
To: dev; +Cc: Qi Zhang, Yang Qiming, Shougang Wang, stable
When create a rss rule with void action, the error log is "Invalid
input set". This patch fix the issue by adding check for the type of
first actions item.
Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling")
Cc: stable@dpdk.org
Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
---
drivers/net/ice/ice_generic_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index ad103d0e8..80ef0e323 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -1873,7 +1873,7 @@ ice_flow_process_filter(struct rte_eth_dev *dev,
return -rte_errno;
}
- if (!actions) {
+ if (!actions || actions->type == RTE_FLOW_ACTION_TYPE_END) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION_NUM,
NULL, "NULL action.");
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow
2020-07-06 9:37 [dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow Shougang Wang
@ 2020-07-07 0:38 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-07-07 0:38 UTC (permalink / raw)
To: Wang, ShougangX, dev; +Cc: Yang, Qiming, stable
> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Monday, July 6, 2020 5:37 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/ice: fix incorrect error log in generic flow
>
> When create a rss rule with void action, the error log is "Invalid input set".
> This patch fix the issue by adding check for the type of first actions item.
>
> Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-07 0:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 9:37 [dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow Shougang Wang
2020-07-07 0:38 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).