From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB8CDA0526; Thu, 9 Jul 2020 02:33:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E3131DA8E; Thu, 9 Jul 2020 02:33:54 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B5607A69 for ; Thu, 9 Jul 2020 02:33:51 +0200 (CEST) IronPort-SDR: Fm+PwPta+UieRjtaUBFHYuodzFM0BqdKgfn5LKarTXeblGBulBQjK9/d01Lpb/Z8ZFDj2ujXAH 2oVVTb9TShyQ== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="127505920" X-IronPort-AV: E=Sophos;i="5.75,329,1589266800"; d="scan'208";a="127505920" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 17:33:50 -0700 IronPort-SDR: 94EK3IdVgCqNPImESAJMar1WLMSpLUQKry0rKZkado4woaRZUhK+2R/QB1xqiw5a1digBv64LR j7bmQGxJHeQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,329,1589266800"; d="scan'208";a="323080662" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jul 2020 17:33:50 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 8 Jul 2020 17:33:49 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 8 Jul 2020 17:33:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0439.000; Thu, 9 Jul 2020 08:33:46 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon , "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Jia" , "Guo, Junfeng" , "Su, Simei" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "viacheslavo@mellanox.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "orika@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 prefix Thread-Index: AQHWQ7a011zWOy0smEWiQz0KNMS5A6j7j+KAgAIBrwD//31JgIAAiJug//+YyoCAAIdUMP//gNWAABD/psD//5paAP/+0wqg Date: Thu, 9 Jul 2020 00:33:46 +0000 Message-ID: <039ED4275CED7440929022BC67E70611548590B2@SHSMSX103.ccr.corp.intel.com> References: <20200612080711.39774-1-junfeng.guo@intel.com> <1845327.VSnYL2Xkle@thomas> <039ED4275CED7440929022BC67E7061154858537@SHSMSX103.ccr.corp.intel.com> <2222669.ed38JIK7Hh@thomas> In-Reply-To: <2222669.ed38JIK7Hh@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, July 8, 2020 10:29 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia ; Guo, Junfeng > ; Su, Simei ; Yigit, Ferruh > ; arybchenko@solarflare.com; > viacheslavo@mellanox.com; jerinj@marvell.com; > ajit.khaparde@broadcom.com; orika@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 > prefix >=20 > 08/07/2020 14:37, Zhang, Qi Z: > > From: Thomas Monjalon > > > 08/07/2020 14:05, Zhang, Qi Z: > > > > From: Thomas Monjalon > > > > > 08/07/2020 13:10, Zhang, Qi Z: > > > > > > From: Thomas Monjalon > > > > > > > 08/07/2020 11:45, Zhang, Qi Z: > > > > > > > > On 2020/7/7 19:06, Thomas Monjalon wrote: > > > > > > > > > 16/06/2020 10:16, Junfeng Guo: > > > > > > > > >> This patch defines new RSS offload types for IPv6 > > > > > > > > >> prefix with 32, 48, > > > > > > > > >> 64 bits of both SRC and DST IPv6 address. > > > > > > > > >> > > > > > > > > >> Signed-off-by: Junfeng Guo > > > > > > > > >> --- > > > > > > > > >> lib/librte_ethdev/rte_ethdev.h | 51 > > > > > > > ++++++++++++++++++++++++++++++++++ > > > > > > > > >> 1 file changed, 51 insertions(+) > > > > > > > > >> > > > > > > > > >> diff --git a/lib/librte_ethdev/rte_ethdev.h > > > > > > > > >> b/lib/librte_ethdev/rte_ethdev.h index > > > > > > > > >> 631b146bd..5a7ba36d8 > > > > > > > > >> 100644 > > > > > > > > >> --- a/lib/librte_ethdev/rte_ethdev.h > > > > > > > > >> +++ b/lib/librte_ethdev/rte_ethdev.h > > > > > > > > >> @@ -538,6 +538,9 @@ struct rte_eth_rss_conf { > > > > > > > > >> #define ETH_RSS_L4_DST_ONLY (1ULL << 60) > > > > > > > > >> #define ETH_RSS_L2_SRC_ONLY (1ULL << 59) > > > > > > > > >> #define ETH_RSS_L2_DST_ONLY (1ULL << 58) > > > > > > > > >> +#define ETH_RSS_L3_PRE32 (1ULL << 57) > > > > > > > > >> +#define ETH_RSS_L3_PRE48 (1ULL << 56) > > > > > > > > >> +#define ETH_RSS_L3_PRE64 (1ULL << 55) > > > > > > > > > > > > > > > > > > PRE32, 48 and 64 are not obvious. > > > > > > > > > Why is it needed? > > > > > > > > > > > > > > > > there is typical usage for NAT64, which use 32 bit prefix > > > > > > > > for > > > > > > > > IPv6 addresses, in this case flows over IPv4 and IPv6 will > > > > > > > > result in the same hash value, as well as 48, 64, which > > > > > > > > also have some corresponding use cases, > > > > > > > > > At least, please add comments for the values of this API. > > > > > > > > > > > > > > > > sure, we will add more comments. > > > [...] > > > > > > > > 32, 48, 64 are typical usage, and consider suffix pair we > > > > > > > > may add later, it will cost 6 bits so far we still have 27 > > > > > > > > bit left, so it looks like will not be a problem in > > > > > > > > following couple > > > releases. > > > > > > > > > > > > > > Having some space left is not a reason to waste it :) If I > > > > > > > understand well, there is no standard for this API. > > > > > > > You are assigning some bits to some usage. > > > > > > > I don't find it generic and flexible enough. > > > > > > > > > > > > Actually IPv6 address prefix is in spec, please check below RFC= . > > > > > > https://tools.ietf.org/html/rfc6052#page-5 > > > > > > > > > > Quoting the RFC: > > > > > " > > > > > the prefix shall be either the "Well-Known Prefix" > > > > > or a "Network-Specific Prefix" unique to the organization > > > > > deploying the address translators. > > > > > The prefixes can only have one of the following lengths: > > > > > 32, 40, 48, 56, 64, or 96. > > > > > (The Well-Known Prefix is 96 bits long, and can only be used > > > > > in the last form of the table.) " > > > > > > > > > > So 40 and 56 are missing. > > > > > > > > Yes, like to add and lets accelerate the progress to abandon the > > > > old APIs :) > > > > > > Please could list which part of the existing API you would like to > > > deprecate in future? > > > > I think it's a new version of rte_flow_action_rss, we need a more > > generic way to describe the RSS input set of a flow But not just a 64 b= its > type, then all ETH_RSS_xxx will be decoupled from rte_flow. >=20 > I was asking what would you deprecate? I think at least those ETH_RSS xxx modifiers from bottom can be deprecated,= since they are only be used by rte_flow >=20