* [dpdk-dev] [PATCH v1] net/ice: fix TCP checksum offload failure
@ 2020-07-28 13:42 Haiyue Wang
2020-07-29 0:01 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2020-07-28 13:42 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang; +Cc: yinan.wang, ting.xu, Haiyue Wang, stable
The L4LEN field of the Descriptor Header Offset for TCP should be the
real length including the TCP options.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/ice/ice_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index cc3139042e..ddf6a93fb2 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2234,7 +2234,7 @@ ice_txd_enable_checksum(uint64_t ol_flags,
switch (ol_flags & PKT_TX_L4_MASK) {
case PKT_TX_TCP_CKSUM:
*td_cmd |= ICE_TX_DESC_CMD_L4T_EOFT_TCP;
- *td_offset |= (sizeof(struct rte_tcp_hdr) >> 2) <<
+ *td_offset |= (tx_offload.l4_len >> 2) <<
ICE_TX_DESC_LEN_L4_LEN_S;
break;
case PKT_TX_SCTP_CKSUM:
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/ice: fix TCP checksum offload failure
2020-07-28 13:42 [dpdk-dev] [PATCH v1] net/ice: fix TCP checksum offload failure Haiyue Wang
@ 2020-07-29 0:01 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-07-29 0:01 UTC (permalink / raw)
To: Wang, Haiyue, dev, Yang, Qiming; +Cc: Wang, Yinan, Xu, Ting, stable
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, July 28, 2020 9:42 PM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Wang, Yinan <yinan.wang@intel.com>; Xu, Ting <ting.xu@intel.com>;
> Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/ice: fix TCP checksum offload failure
>
> The L4LEN field of the Descriptor Header Offset for TCP should be the real
> length including the TCP options.
>
> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 13:42 [dpdk-dev] [PATCH v1] net/ice: fix TCP checksum offload failure Haiyue Wang
2020-07-29 0:01 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).