From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6687CA052B; Wed, 29 Jul 2020 02:07:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D2411150; Wed, 29 Jul 2020 02:07:33 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6AC2910A3 for ; Wed, 29 Jul 2020 02:07:31 +0200 (CEST) IronPort-SDR: eq3A0hBah82gm+oQg8zrREvc1lkRuxv3+ZVn7F10Pd3CWhxNVaqUWxAGY246jqUCFABgE6mYq6 hZF/9CxcCFWw== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="151318170" X-IronPort-AV: E=Sophos;i="5.75,408,1589266800"; d="scan'208";a="151318170" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 17:07:30 -0700 IronPort-SDR: z7Tpe1LxMEfSy0rf8zGRvwVhAE2g7TC8qBBCR204WfPfquAS7cF0rw75TtE2Txyyl3abt1Njbi 9AuEhRZ843kQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,408,1589266800"; d="scan'208";a="272471672" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2020 17:07:29 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jul 2020 17:07:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jul 2020 17:07:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0439.000; Wed, 29 Jul 2020 08:07:16 +0800 From: "Zhang, Qi Z" To: "Sun, Chenmin" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix a wrong bitmap free call Thread-Index: AQHWZJLA+s37cD1/+UKg8iQZt5Mdkqkdrv3Q Date: Wed, 29 Jul 2020 00:07:15 +0000 Message-ID: <039ED4275CED7440929022BC67E7061154868448@SHSMSX103.ccr.corp.intel.com> References: <20200728125058.50292-1-chenmin.sun@intel.com> In-Reply-To: <20200728125058.50292-1-chenmin.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix a wrong bitmap free call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sun, Chenmin > Sent: Tuesday, July 28, 2020 8:51 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Sun, Chenmin > Subject: [PATCH] net/i40e: fix a wrong bitmap free call >=20 > From: Chenmin Sun >=20 > This patch fixes the coverity warning #361024. > rte_bitmap_free() is not a right way to free a bitmap, replacing it with > rte_free(). >=20 Coverity issue: 361024 Fixes: febc61d350bf ("net/i40e: optimize flow director update rate") > Signed-off-by: Chenmin Sun Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 05d5f2861..a17bc9bab 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1870,7 +1870,7 @@ i40e_fdir_memory_cleanup(struct i40e_pf *pf) > if (fdir_info->hash_table) > rte_hash_free(fdir_info->hash_table); > if (fdir_info->fdir_flow_pool.bitmap) > - rte_bitmap_free(fdir_info->fdir_flow_pool.bitmap); > + rte_free(fdir_info->fdir_flow_pool.bitmap); > if (fdir_info->fdir_flow_pool.pool) > rte_free(fdir_info->fdir_flow_pool.pool); > if (fdir_info->fdir_filter_array) > -- > 2.17.1