Re: [PATCH v9 1/9] net/zxdh: add zxdh ethdev pmd driver

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/1/2024 6:21 AM, Junlong Wang wrote:
> Add basic zxdh ethdev init and register PCI probe functions
> Update doc files.
> 
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---
>  MAINTAINERS                            |  6 ++
>  doc/guides/nics/features/zxdh.ini      |  9 +++
>  doc/guides/nics/index.rst              |  1 +
>  doc/guides/nics/zxdh.rst               | 31 +++++++++
>  doc/guides/rel_notes/release_24_11.rst |  4 ++
>  drivers/net/meson.build                |  1 +
>  drivers/net/zxdh/meson.build           | 18 +++++
>  drivers/net/zxdh/zxdh_ethdev.c         | 92 ++++++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_ethdev.h         | 44 ++++++++++++
>  9 files changed, 206 insertions(+)
>  create mode 100644 doc/guides/nics/features/zxdh.ini
>  create mode 100644 doc/guides/nics/zxdh.rst
>  create mode 100644 drivers/net/zxdh/meson.build
>  create mode 100644 drivers/net/zxdh/zxdh_ethdev.c
>  create mode 100644 drivers/net/zxdh/zxdh_ethdev.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8919d78919..a5534be2ab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1051,6 +1051,12 @@ F: drivers/net/virtio/
>  F: doc/guides/nics/virtio.rst
>  F: doc/guides/nics/features/virtio*.ini
>  
> +ZTE zxdh
> +M: Lijie Shan <shan.lijie@zte.com.cn>
>

You have your sign-off in the patch series, but adding someone else as
maintainer?
We need someone that has technical expertise on the code, is there a
reason to not add your name as maintainer.

> +F: drivers/net/zxdh/
> +F: doc/guides/nics/zxdh.rst
> +F: doc/guides/nics/features/zxdh.ini
> +
>

Minor comment, rest looks good to me:

Please move this below "Wind River", this list is alphabetically shorted
on company name. Last bit of the list is virtual drivers without
specific company associated with them.

<...>

> diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
> new file mode 100644
> index 0000000000..5b6c9ec1bf
> --- /dev/null
> +++ b/drivers/net/zxdh/zxdh_ethdev.c
> @@ -0,0 +1,92 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2024 ZTE Corporation
> + */
> +
> +#include <ethdev_pci.h>
> +#include <bus_pci_driver.h>
> +#include <rte_ethdev.h>
> +
> +#include "zxdh_ethdev.h"
> +
> +static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
> +{
>

DPDK syntax is to have return value in a separate line, like:
static int
zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
{

This is for all files in this series, can you please update all?