From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F256145C4F; Sat, 2 Nov 2024 01:57:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5539402B7; Sat, 2 Nov 2024 01:57:38 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2069.outbound.protection.outlook.com [40.107.236.69]) by mails.dpdk.org (Postfix) with ESMTP id E72164029A for ; Sat, 2 Nov 2024 01:57:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WGLhXuBpuzGZBtb15wQ5BXT0nH+9aZVyF2/w/umvn7TvgOq3CXAdbvLfDNE4kux7NoLOj+c4OeG54qxI+sgMipQBAGgxj0BMbDIDpOqnkHPRbGUdAT0p2zD9bNozfGqJUFqIBVq3Y1HR3THrdR3JXVpryBTBx962Cg7P9oOpwFNF1DvZObr6XmHjCIY11X/D3eAW8dNjM/DQUoUAYEMu0Xqb0vLCpWxYLlbQo9MGkFPD46bj4BcO5WrGJflKCK2K3VAippyHC+iGNlwxcf+icnbF1f/Jo7w9BpfFg9gNrQ+8mdO2uAV1NOm5j93YzkKN5mrN5LjMqnpXBr03HLeA+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghyjlvfiw8iHgJevDoCRoh3lp8tBdXa2wMPsGvJiO1E=; b=a/LCkee85FP5h6RpYC6wiNX/41xgc55w5/teTjH9mkaui36kKN1jMH660VbBC4d32ZmQcS5CXqfTgipCLyvq5P43hDyGyOj5YVfxcmd8vwTYqxczELpZsWOgg8vI3wtYAKITcSYZU9FkPAQA2dUyfXZkdtakah3vwgQv7FQh7jDS270IXzvc3NaQc88mEhHnjnyYxXMNJvI8kTyAuhrRx93xx03LRQ0y4PzsZyzx49jIZjOl2l/y7JU3lB9uOUqmsRkINbn1ZP6gVS++W8a6LS/7RwxSRtgPgOF19wBHzowEveN0pxSULFLZXd/nNPzn8ccpOEH0nNaXtzgyhPY2HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghyjlvfiw8iHgJevDoCRoh3lp8tBdXa2wMPsGvJiO1E=; b=KGC5OiKJ8RtkvwFiIl7piArW01q/wJ9jd1qQXkvGC1uEgUeEXcDYFoCtFnAWo3WIqD9oaEmgDV5sdG1RZmJq430q5qBYqoSkwuFZyhx+XSWeLDdhKLOMKN9IKskOCvhu9rah6bP2W2UZQo0UPrArvrkxLIo4IRNnx7eafjerKNU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB8920.namprd12.prod.outlook.com (2603:10b6:806:38e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.23; Sat, 2 Nov 2024 00:57:34 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sat, 2 Nov 2024 00:57:34 +0000 Message-ID: <03aa5548-44fc-4396-9708-cbdcff74cbc8@amd.com> Date: Sat, 2 Nov 2024 00:57:28 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/9] net/zxdh: add zxdh ethdev pmd driver To: Junlong Wang , dev@dpdk.org Cc: wang.yong19@zte.com.cn, Lijie Shan References: <20241030090124.2540776-2-wang.junlong1@zte.com.cn> <20241101062156.2637339-1-wang.junlong1@zte.com.cn> <20241101062156.2637339-2-wang.junlong1@zte.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241101062156.2637339-2-wang.junlong1@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0549.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::18) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB8920:EE_ X-MS-Office365-Filtering-Correlation-Id: cf879759-761f-472d-2b8c-08dcfad95660 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OUUwQ0lYQm91ZHMwbGVZSWdzY3BYcVhIVGhwRmQ2R2lSUk9pL2g3eVF5TU11?= =?utf-8?B?dGQxQmFzQ1JXSnNSZmNrcG9QdUVWeksvMG5vVzZFek9xc0xUamlTdUtSOW1j?= =?utf-8?B?T1VLSEFEQ1d0NzNXSnF5NWdMU0pBZkZ1ckIyZnNPTmx3Zkw0SnRLYVE3Vm1a?= =?utf-8?B?WW9mSHFlTXdVYzVhR0cxMENnakNtSlhlbHlLbHFFRkxqUXpmSmZ5dmJaZ0VJ?= =?utf-8?B?dTMwM2FwZncvR0RwNklOVXg5TDBoL1V6blpKQlVHU29JMDkzQmJsYWtvaUFX?= =?utf-8?B?ejVoelMyQmZGTDlQcU9JOUJJeklXS3NhNk53d3pMdTg1aHdRT0FUNWJBVUJK?= =?utf-8?B?U2lDb05nTXVCU1FKcnVVYjBHMlJYYkxPR3lKSmRMZERLZEV2a0QxRFh1c3R4?= =?utf-8?B?L0hmUCsxRDNoVzlIakh0Y1IwMkplenpvTjMyRTBRM3pjWERtRHFrc0JIa3Ni?= =?utf-8?B?UVpod1pnYWlFcE1EaEVVMkdYV2pvd2U5bDBNT1p0bEJscmtycUdJTnkxbHVz?= =?utf-8?B?VkNxWnRjS3pQVklsdFJKTzNHQ0dsZWo3MElGVVhkM1BPN3dpZVRvalhJK2VV?= =?utf-8?B?anY1K0w4eDR2RGVwRWpWNVh1TFdqcVpMWVUwd1NROVJJa3U0ellmYmNRZ3Q3?= =?utf-8?B?UTZlUnFLNnpWemZJYXdxampQRG54Qjh2REZadjFqYTBlMHpnc25YSFg1N3RX?= =?utf-8?B?bTVTcVZ5Um0vaDZ3R3JlajVPck1ING1nMnJ6bVFDdmRRSm9uUGhRc2JKNmpX?= =?utf-8?B?N1d2L0RCcXY2ay9sdXJVRnFacStuRGxhandMdnVjVis0Q0RDcWExcjNTT09j?= =?utf-8?B?aVBTS3JheFZBWWhGRkFsb0xnTzJvU01FS3B4bWgwdjBLUHJUMWlycXExZTky?= =?utf-8?B?Wk5MSEtpenlWTThPMGY5WXVPRDliQ2lML3pqeW1pc0w1bTdJeGxiMktnWjBI?= =?utf-8?B?UmVrdnhPcnVaY3c5em1VRmhoejJnUEtjb1hDM0g5SFI1NFBlbUYrMHViQ000?= =?utf-8?B?c2dzbVdLRXFYcUxiTUMzWU5KSHB1aXhPVDR2TGx0WHZIbUhKbUN2REtHTjVH?= =?utf-8?B?WlpsR3piRURRUkZoYi9ocDdxOW9uQklMeUVXcDVBUklZdFVGNk1DSjA3UjEw?= =?utf-8?B?dVo2YXg4b1NjR1o0dEFsQ2xPYWhadmk3VUZBcjBPMWZ2TU5pdE9JZFNjSXBr?= =?utf-8?B?ZUcvUGlMNkFocTFUUC95eFlucnM3eWt3T2JiWGtqMmFnbFlEOHFQN1hNQ1lF?= =?utf-8?B?ek1GWmZWM09yNHRvL0YzZW9hN0JyU05HR3FEemo4Tm4yMFZKMmd1Q0FNM3Bx?= =?utf-8?B?aklJM1dSaG5HTVVkUkxRU0ZEQ0R2bWw0ZVRQa0NubnRmSEFnZG04L0o2WFJR?= =?utf-8?B?aFBWdEd6bU9DL0ZhSWhvM2tNdmwyTHdpS0k3Y2hZTXJXWVFIN0RQR21uRk9l?= =?utf-8?B?SXBiUDliUmFBQXdQRjdmbXIwQ2g1dVlxUHp2NmFjU3hiTm9ZVGg0NURSQWR6?= =?utf-8?B?MXdGQnJvZzN3TXBub0RUTHhQYWsrZ2dQakJjTy9SNjRhcmFkU2E3dTFsbm5G?= =?utf-8?B?OW0xOU1nYnMzaklKSGtlZmFmYkVtNXpsQTFVN2ZJM0dYekF5RVUrR3NtMThq?= =?utf-8?B?NW5kQXFtaG05UVpHRG5CbTNMQUtOeUYrcmF0cUt5V0dWNmhKbHc1aERxSGhS?= =?utf-8?B?VVNtSGpFV1BPSlJxeEp0OFhIOXBNbHpVT1ozZWhITGJ2YkovWDhka2lSZmV4?= =?utf-8?Q?SRWDE7DhbAAevDMwSgD7zNLsSTP0l6xtb8wROcx?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2xWNytNNk9vY1hPV01BeXlKY0oxa0cwcHRYeEk5b0dNM1paMW1wSERyR1ha?= =?utf-8?B?Rlc0RXhBcUtzSlFDMXlCeXZtT0MwRzNpcGhOQXdZb3QvL2QyVHlveVBnaURx?= =?utf-8?B?UnRwdkh0dTFNdnB3Zk5xNks1L01aT3lDMGtZVE5kUmVocHpST3N6Z0UzWkdH?= =?utf-8?B?WHUwT1M0TFZvQWpDemdscWhEdnAvMkhKcVBGTU1pMEtKRWcyNGw1UU4vMHJO?= =?utf-8?B?cHhyUzRvcWVDemYyTTRQNGJQamw1TUJQWXRTR003VzVBbkNjSXBrMkJOdHVP?= =?utf-8?B?MmlEQXVOTk5nNC9wTURMckhKUk1QdzZEOVIwTVFyQUVnWVBhTGZwOTFvSnc0?= =?utf-8?B?YjNSV0JPbzA1SmRtaXVmWVR4eUdrdVc3ZmRHUG1QUC93ZmNNTm9xWGZ5ZTFq?= =?utf-8?B?dmUzeTRWeldBSTh4YVhwd25QZWxBL016a2dQbGl1QklHT21aUWN2cU8yQ2ky?= =?utf-8?B?SUo2Mm9zQ0FMaXpwN3hGM1pVUGllN21waUx3M08yUVc2Tk5vY2NOSU41a2Z4?= =?utf-8?B?b2pQb3Y0akptVFBuZHhHMWcwTUFDOEZ1LzBVMDFsUEFTYm1VeHZoNU5ZQndC?= =?utf-8?B?UGEwN1hzT1RYc3h1bmdPblo4M1Fxa3dmTTI1M3ZzcDh0cFJZaWdxM2NrTStn?= =?utf-8?B?ek1ZQldyQXlLYUhxUjFFK3REMGJMS2VSZWtES3I3TFlPTG1mQlZRZ2x2Ly9p?= =?utf-8?B?dFAvZVBWZHZWK3RnMWd6S25rQzlDeHVpSWs0bDRpc1dZUG5MSTI4OWM3TWdS?= =?utf-8?B?VWNxblBKQnh4TmpHN09PT0ZXbmxKY2t1YUFpbVhTVk5xZkFlUFB1K2QvYVMv?= =?utf-8?B?bm5HTmRwNFhndlVMSTBReDFieiszVGpnTW0rOG91cVdoaEhsTm1pVFRDdnl2?= =?utf-8?B?WDcxa1hIUHUrR0NyeU03djk1OCtsZVpkTkhlelNWL3NHWWJKRStHTGdOckxs?= =?utf-8?B?ZDhjL3pSVytyUVh4MytRNEZONFptd0RLcGQ3K3AzRnpCeE5ybmtoSGlwdzUv?= =?utf-8?B?ZENxcnYyY1ZPbXpwNm1xWmRtbWxiNmpuL1FTZTVKZmFMNDRPVkxwMkVzcUhQ?= =?utf-8?B?SkxlYmpwN3NhTmYyc01oVVVpSU1VTDhEQXhTK1Z6dGI0VmtMQzRBRGtBbFFH?= =?utf-8?B?bFYzTE1qOTBRRFRLMDBkam9sdFlBSTgxazIyeCtzeE9YWFZFQ0NpSCtUUEpM?= =?utf-8?B?RURwNG9jSEYyR090eHNtK1BqMUxMc1diMFBiVjVONzR4dktOaW9idUh6VVJu?= =?utf-8?B?YzFzNTU3VlFCUmFNdUNMQmpGVWJZblhsdmUvYXo3RjVZRWJTZnFHKy9RTklF?= =?utf-8?B?azdhUXNvL2QwZkEwTlMrZ1R1SldZUmpHY0IvdFUwUmlVSlQ0WXJOY3lWNmxq?= =?utf-8?B?WFZPTVJOWDNhRk9GeUVaWHFkU2tBeFc4OTZNcnExc1dmSENRV1IwRmVHTWYy?= =?utf-8?B?cWErbUJ6dCtVM2ZFalN3UGNmWDJiMEJmNklRaXVXbnNyRTNYcWI2L2pLeStk?= =?utf-8?B?REc5a1p4SVVCQkJQQ210UlM4SE1EUGUrdW5qSk5BaEtFYnJIRFhyOHlKM3Rz?= =?utf-8?B?cHdWVWw4YXcrdzNSRW5FYjY3cnl5MW16bnJkWjBDRm11b21ycDFvUFdyeSth?= =?utf-8?B?R011dHhORWlVbVdXWk0xYitEYW9VdWh2YkhTTTA0MGJGTGRUN3RHOVVTMy9r?= =?utf-8?B?V3lWWWZNbnMxbSsvcnBlZE5La3IyR1V1OU9sTUxCVlBCNjZEUEJTZ09YYVRH?= =?utf-8?B?UjV6R00rK24rQk1ZTGIvK0JoYWFCYWJaMVNoamRoU0o5dCtBQUwxaUVwbDBD?= =?utf-8?B?Y2w2QkhCRHNHOGJNaDV6OERWUU84NnFrcTRWSVNEV29xTm9uVCtWNEFUNWFF?= =?utf-8?B?UVdXOUpQRFBnRVh4WXVHbWF1R2dHM0Eydjc0amZ6aXJqNGdrNlBmOGEzVDFj?= =?utf-8?B?b1FLaldXUXkwSUorMXdGclN0MnJ4TE92VGZaemd1am51ck55ZjZBQzV0d2Nz?= =?utf-8?B?Z0NXNVdUejZES0dZR2p0c0J4Qm52MkFucG1oMHdvRFpqdWR6YWFCQmR1R1FO?= =?utf-8?B?Vk4xdnhqVS9aTXltbVdOTTk1clg2WGd0RzVWRGNNSEtvc1pOUytveXVtajRs?= =?utf-8?Q?PFzvaXfa9J+e6JaNRMO9nerjn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf879759-761f-472d-2b8c-08dcfad95660 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2024 00:57:34.4453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qOlABXFAuSdqPT+KDdTZGkD5j5pYLFJdoJoNIXJWxUDdM24baWigMABM5xSCjKSS X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add basic zxdh ethdev init and register PCI probe functions > Update doc files. > > Signed-off-by: Junlong Wang  > --- >  MAINTAINERS                            |  6 ++ >  doc/guides/nics/features/zxdh.ini      |  9 +++ >  doc/guides/nics/index.rst              |  1 + >  doc/guides/nics/zxdh.rst               | 31 +++++++++ >  doc/guides/rel_notes/release_24_11.rst |  4 ++ >  drivers/net/meson.build                |  1 + >  drivers/net/zxdh/meson.build           | 18 +++++ >  drivers/net/zxdh/zxdh_ethdev.c         | 92 ++++++++++++++++++++++++++ >  drivers/net/zxdh/zxdh_ethdev.h         | 44 ++++++++++++ >  9 files changed, 206 insertions(+) >  create mode 100644 doc/guides/nics/features/zxdh.ini >  create mode 100644 doc/guides/nics/zxdh.rst >  create mode 100644 drivers/net/zxdh/meson.build >  create mode 100644 drivers/net/zxdh/zxdh_ethdev.c >  create mode 100644 drivers/net/zxdh/zxdh_ethdev.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8919d78919..a5534be2ab 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1051,6 +1051,12 @@ F: drivers/net/virtio/ >  F: doc/guides/nics/virtio.rst >  F: doc/guides/nics/features/virtio*.ini >   > +ZTE zxdh > +M: Lijie Shan  > You have your sign-off in the patch series, but adding someone else as maintainer? We need someone that has technical expertise on the code, is there a reason to not add your name as maintainer. > +F: drivers/net/zxdh/ > +F: doc/guides/nics/zxdh.rst > +F: doc/guides/nics/features/zxdh.ini > + > Minor comment, rest looks good to me: Please move this below "Wind River", this list is alphabetically shorted on company name. Last bit of the list is virtual drivers without specific company associated with them. <...> > diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c > new file mode 100644 > index 0000000000..5b6c9ec1bf > --- /dev/null > +++ b/drivers/net/zxdh/zxdh_ethdev.c > @@ -0,0 +1,92 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2024 ZTE Corporation > + */ > + > +#include  > +#include  > +#include  > + > +#include "zxdh_ethdev.h" > + > +static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev) > +{ > DPDK syntax is to have return value in a separate line, like: static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev) { This is for all files in this series, can you please update all?