From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8588A0C45; Wed, 20 Oct 2021 09:44:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8931D4117C; Wed, 20 Oct 2021 09:43:57 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id EEAB840150 for ; Wed, 20 Oct 2021 09:43:56 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 87E117F5F5; Wed, 20 Oct 2021 10:43:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 87E117F5F5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634715836; bh=eHtOcjMeKeEqBF3gSsC37a51QjcOohFkOc2niEkF63E=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=mEgtmsVv4thajAUJ5tqSi4CKPw5VlSvrUFPvLQtq8uh7wByJzPHVfPp8eXK6RgCJ4 Q8BCf3JQlpwtp2xZw+TsnwryB3CIH9pHmDwEXgUjcyn5DEUsa/r1LGuwd817Yfo+d8 hU63jI400qTB0NjNdJB2+ZayVfGR17Z4f+Cvx1ek= To: Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, Konstantin Ananyev References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> <945d03fb-251b-eb75-f815-950754652b7b@oktetlabs.ru> <0ce43d7d-2d01-d332-1a22-1062a7ea489e@intel.com> <4058515.qi23bM2isA@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <03ae52d4-4f54-e7d1-f422-5a19973134a6@oktetlabs.ru> Date: Wed, 20 Oct 2021 10:43:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <4058515.qi23bM2isA@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/20/21 1:20 AM, Thomas Monjalon wrote: > 20/10/2021 00:05, Ferruh Yigit: >> On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: >>> On 10/19/21 2:55 PM, Ferruh Yigit wrote: >>>> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: >>>>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved >>>>> right now is a good chance to make a cleanup. >>>>> >>>>> No strong opinion, but I think it would be useful for the future. >>>>> >>>>> Make be at least some fixes from below could be accepted. >>>>> >>>>> Andrew Rybchenko (5): >>>>> ethdev: avoid documentation in next lines >>>>> ethdev: fix Rx/Tx spelling in just moved structures >>>>> ethdev: remove reserved fields from internal structures >>>>> ethdev: make device and data structures readable >>>>> ethdev: remove full stop after short comments and references >>>>> >>>> >>>> Overall +1 to these changes, I think this release is the opportunity >>>> to have changes like this. >>>> >>>> But as far as I can see only new moved code updated in 'ethdev_driver.h', >>>> why not update whole 'ethdev_driver.h'? >>> >>> Simply don't want to complicate search by git blame because of cosmetic >>> changes. No strong opinion, but decided to go this way for now. >> >> Normally agree to NOT get cosmetic changes because the reason you mentioned, >> noise in the git history. But in this release we already shuffled things a bit, >> that is why I think it is good opportunity to get these kind of changes. >> >> Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, >> like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. >> >> I also don't have strong opinion, but my preference is either fix all, or none. >> Lets get some more comments. > > OK to fix all, given ethdev is already shuffled a lot. > I've made the next step. See v2. Let me know if it is OK, too much or insufficient.