From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E45EF4CE4; Fri, 21 Sep 2018 02:05:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 17:05:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,282,1534834800"; d="scan'208";a="71683431" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.22.231]) ([10.252.22.231]) by fmsmga007.fm.intel.com with ESMTP; 20 Sep 2018 17:05:35 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Andrew Rybchenko Cc: dev@dpdk.org, Igor Romanov , stable@dpdk.org References: <1535732192-3058-1-git-send-email-arybchenko@solarflare.com> <20180919151449.s2em4hgf7hti5jfg@bidouze.vm.6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <03b46ead-c4b3-c3bf-5a97-b7930d7109a7@intel.com> Date: Fri, 21 Sep 2018 01:05:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180919151449.s2em4hgf7hti5jfg@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix crash on slave queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 00:05:42 -0000 On 9/19/2018 4:14 PM, Gaëtan Rivet wrote: > On Fri, Aug 31, 2018 at 05:16:32PM +0100, Andrew Rybchenko wrote: >> From: Igor Romanov >> >> Releasing a queue that is already released by slave may cause a >> segmentation fault. For example, after a successfull device >> configuration a queue is set up. Afterwards the device is reconfigured >> with an invalid argument, forcing slaves to release the queues >> (e.g. rte_eth_dev.data.tx_queues). Finally the failsafe's queues >> are released. The queue release functions also try to release slaves' >> queues using ETH(sdev)->data->tx_queues which is NULL at the time. >> >> Add checks for NULL slaves' Tx and Rx queues before releasing them. >> >> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") >> Cc: stable@dpdk.org >> >> Signed-off-by: Igor Romanov >> Signed-off-by: Andrew Rybchenko > > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.