From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81540A0548; Tue, 31 May 2022 16:43:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 710254067B; Tue, 31 May 2022 16:43:04 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 64E9540143 for ; Tue, 31 May 2022 16:43:03 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id BDA7586; Tue, 31 May 2022 17:43:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru BDA7586 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654008183; bh=bkZ7aOXKBgLIcCdjoVJ7nQbcx3gmW91aFxLTJo3JtYs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XkhAfVof/zqjER9oVWdNAteFzuKnFhEGLAFK8MrFyaMbH8c4yOcerh0+Zh9NoBjp3 T93CQP4R28CmfJ/kx9MKYUZv4P/iZqXYmOfS9pcMenNk0y8Krk6b6FSNhgW53Ickck 9etl2CGRyr3EsQwm5K2Z02OUZuIUWwmAS27TP7fU= Message-ID: <03cc5d15-a92f-f041-e8d1-c07fd73b0f85@oktetlabs.ru> Date: Tue, 31 May 2022 17:43:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v9 0/5] add telemetry command for show module EEPROM Content-Language: en-US To: Robin Zhang , dev@dpdk.org Cc: thomas@monjalon.net, kevinx.liu@intel.com References: <20220525031446.72578-1-robinx.zhang@intel.com> <20220526073215.428410-1-robinx.zhang@intel.com> From: Andrew Rybchenko In-Reply-To: <20220526073215.428410-1-robinx.zhang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/22 10:32, Robin Zhang wrote: > Introduce a new telemetry command /ethdev/module_eeprom to show module > EEPROM for each port. The format of module EEPROM information follows > the SFF(Small Form Factor) Committee specifications. > > Current the format support SFP(Small Formfactor Pluggable)/SFP+/ > QSFP+(Quad Small Formfactor Pluggable)/QSFP28 with specs SFF-8079/ > SFF-8472/SFF-8024/SFF-8636. > > Afther run the /ethdev/module_eeprom command, telemetry client will > show the module EEPROM information. We keep the same information content > compare with Linux utility ethtool, refer to command 'ethtool -m' of > ethtool v5.4. > > v9: > - Optimize code format and commit log > > v8: > - refine code > > v7: > - remove "#include " in lib/ethdev/sff_8472.c > > v6: > - refine code > > v5: > - fix CI robot compile fail issue > > v4: > - remove all printf in primary application, only show information > in tememetry client > - refine codes > > v3: > - split up codes into several patches for better reivew > > Robin Zhang (5): > ethdev: add telemetry command for module EEPROM > ethdev: add common code for different SFF specs > ethdev: support SFF-8079 module information telemetry > ethdev: support SFF-8472 module information telemetry > ethdev: support SFF-8636 module information telemetry > > devtools/words-case.txt | 1 + > lib/ethdev/meson.build | 5 + > lib/ethdev/rte_ethdev.c | 3 + > lib/ethdev/sff_8079.c | 401 +++++++++++++++++++ > lib/ethdev/sff_8472.c | 280 ++++++++++++++ > lib/ethdev/sff_8636.c | 764 +++++++++++++++++++++++++++++++++++++ > lib/ethdev/sff_8636.h | 590 ++++++++++++++++++++++++++++ > lib/ethdev/sff_common.c | 319 ++++++++++++++++ > lib/ethdev/sff_common.h | 173 +++++++++ > lib/ethdev/sff_telemetry.c | 150 ++++++++ > lib/ethdev/sff_telemetry.h | 27 ++ > 11 files changed, 2713 insertions(+) > create mode 100644 lib/ethdev/sff_8079.c > create mode 100644 lib/ethdev/sff_8472.c > create mode 100644 lib/ethdev/sff_8636.c > create mode 100644 lib/ethdev/sff_8636.h > create mode 100644 lib/ethdev/sff_common.c > create mode 100644 lib/ethdev/sff_common.h > create mode 100644 lib/ethdev/sff_telemetry.c > create mode 100644 lib/ethdev/sff_telemetry.h > Series-acked-by: Andrew Rybchenko I've updated the patch series a bit to remove unused/undefined functions from the first patch to move corresponding code to subsequent patches. Also I've added release notes. Please, take a look. Applied to dpdk-next-net/main, thanks.