From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1185C45C22;
	Fri,  1 Nov 2024 03:07:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 957B943283;
	Fri,  1 Nov 2024 03:07:08 +0100 (CET)
Received: from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])
 by mails.dpdk.org (Postfix) with ESMTP id ACAC840265
 for <dev@dpdk.org>; Fri,  1 Nov 2024 03:07:06 +0100 (CET)
X-QQ-mid: Yeas2t1730426817t432t54103
Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com
 [60.177.96.245])
X-QQ-SSF: 0000000000000000000000000000000
From: =?utf-8?b?Smlhd2VuIFd1?= <jiawenwu@trustnetic.com>
X-BIZMAIL-ID: 3937897838556123219
To: "'Ferruh Yigit'" <ferruh.yigit@amd.com>,
	<dev@dpdk.org>
References: <20241023064836.2017879-1-jiawenwu@trustnetic.com>
 <20241028023147.60157-1-jiawenwu@trustnetic.com>
 <20241028023147.60157-8-jiawenwu@trustnetic.com>
 <fc2792c4-e259-4a96-9856-3a15de7ee27e@amd.com>
In-Reply-To: <fc2792c4-e259-4a96-9856-3a15de7ee27e@amd.com>
Subject: RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics
Date: Fri, 1 Nov 2024 10:06:56 +0800
Message-ID: <03d001db2c02$ba5ac830$2f105890$@trustnetic.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGXIFrpZ1KNQpKKY/LzcUfCKsmTCQHAYxNLAQBVWmQBpt007bMGhEuw
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1
X-QQ-XMAILINFO: Mi9kkal7U7b3YGYcim35aMNmaxC++DYelfeSM8tM5aKpJCjgVQEfc7xX
 iLXb6Bq6QRZkyuMBjDdrNb0u2jGUoIUEW60n94h0BUq8Fr/N5AL1DHp42lfouKiyMpkPHZM
 u9x6Y1hJZur2+EXSlR/dRm79zh4e5i2zKeJv3Cv1LNDt3TrzbihMedGHNSqlXEwDyxt26DL
 FvTgKb3HYt/8C2TyLuWxGpp5Zu/HQujZV82cazoJCIwni4t51EKRZVUInw8jYYNQxKMS6hu
 lCZmKlF3tMQNZXwoXE+0eAirbFjRFDjaIWTjHctNM1BHx1bt8KxtYGtatisgls/xRiibGUx
 o+d6EF7tVWY71y1x/PPVxV6gAuvpKXZN+fQWqnBCRlYXFWmsjE10pzc7tPALv5LVG5NiYUJ
 Z1yV4nNdtSjqlXq0rZlq/vSURo32x9ddrm2bpzr9PAS3aIH5UJzQxzoHwj1BXc1yR6Yk+7W
 zTKb0YS0Krwjd63xnM61P89Rv+vKmlQqqBWiJyv+hhJReyGFk92LUUld3tq3pxmey9+aXwT
 N28qHTi817oS5K3skIUvr032JIKG/R11YPupykyZbdkkJjUd9pBxRUO5Py1PW44rPcZvEWv
 Com2MahbfO7lS6HUE9US7NZKHJmlCwCnv0TO7wmD9MY2wOfGdLhvN8WrC3P597W8sfSlIcO
 ewum8LCH3pTXz00b7LjE6cwB3Xk0ZBAVIfmu/pFQUiQ6IoUz0IImDyzVYIlS63sgmpuslkw
 cI5veY4phENXEu8f9zghn+PBuWnSlgXYjczuuMBr1ZXHEIBYDsYe+eVqRBjVaLzIp4bTloN
 gsTNffEQmFDxhhywmAbK9u1gcSNLjO0dXDVXBf0fQS5qD89CjfoUWAouDaIEmmDMEzFbFmk
 73gBe3RzgipAcOl2E93HybsvHuU+i4uxzG+9p+VKBezrK8k20wI3ABRd0BIecBtYr0mOgi5
 jQlF2n5k5ScTfAE13NLXYAVucgHMz6gMbGte/j5mcJKC9zQ==
X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
> >  		if (!txq->resetting)
> >  			continue;
> >
> > +		txq->desc_error++;
> >
> 
> Why error value is increased in this function, which resets the Tx queue?
> Is the intention to reset the error value here?

When there is a desc error to cause Tx ring hang,  the interrupt directs to
reset of the queue. So we increase the error count in the specific queue
reset function. The queue is reset, but the error that led to the resetting
is recorded. The error count is only reset at the setup function.