Re: [dpdk-dev] [RFC] ethdev: mark old ETH_LINK macros as deprecated

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/29/2021 10:47 PM, Stephen Hemminger wrote:
> The new definitions should be favored and used by all new code.
> 
> Fixes: 295968d17407 ("ethdev: add namespace")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   lib/ethdev/rte_ethdev.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 24f30b4b2890..9709a944b752 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -367,17 +367,17 @@ struct rte_eth_link {
>    * Constants used in link management.
>    */
>   #define RTE_ETH_LINK_HALF_DUPLEX 0 /**< Half-duplex connection (see link_duplex). */
> -#define ETH_LINK_HALF_DUPLEX     RTE_ETH_LINK_HALF_DUPLEX
> +#define ETH_LINK_HALF_DUPLEX     RTE_DEPRECATED(RTE_ETH_LINK_HALF_DUPLEX)
>   #define RTE_ETH_LINK_FULL_DUPLEX 1 /**< Full-duplex connection (see link_duplex). */
> -#define ETH_LINK_FULL_DUPLEX     RTE_ETH_LINK_FULL_DUPLEX
> +#define ETH_LINK_FULL_DUPLEX     RTE_DEPRECATED(RTE_ETH_LINK_FULL_DUPLEX)
>   #define RTE_ETH_LINK_DOWN        0 /**< Link is down (see link_status). */
> -#define ETH_LINK_DOWN            RTE_ETH_LINK_DOWN
> +#define ETH_LINK_DOWN            RTE_DEPRECATED(RTE_ETH_LINK_DOWN)
>   #define RTE_ETH_LINK_UP          1 /**< Link is up (see link_status). */
> -#define ETH_LINK_UP              RTE_ETH_LINK_UP
> +#define ETH_LINK_UP              RTE_DEPRECATED(RTE_ETH_LINK_UP)
>   #define RTE_ETH_LINK_FIXED       0 /**< No autonegotiation (see link_autoneg). */
> -#define ETH_LINK_FIXED           RTE_ETH_LINK_FIXED
> +#define ETH_LINK_FIXED           RTE_DEPRECATED(RTE_ETH_LINK_FIXED)
>   #define RTE_ETH_LINK_AUTONEG     1 /**< Autonegotiated (see link_autoneg). */
> -#define ETH_LINK_AUTONEG         RTE_ETH_LINK_AUTONEG
> +#define ETH_LINK_AUTONEG         RTE_DEPRECATED(RTE_ETH_LINK_AUTONEG)
>   #define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */
>   /**@}*/
>   
> 

This definitely prevents using old macros, btw there are bunch of them renamed
in this release.

My concern is if it cause too much noise, if we are OK with that I can send a
patch that covers all renamed macros.