DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/sfc: remove queue xstats auto-fill flag
@ 2021-09-28 14:16 Andrew Rybchenko
  2021-09-28 16:48 ` [dpdk-dev] [PATCH v2] drivers/net: " Andrew Rybchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Andrew Rybchenko @ 2021-09-28 14:16 UTC (permalink / raw)
  To: dev; +Cc: stable

Driver does not provide per-queue statistics. So, there is no point
to have these misleading zeros in xstats.

Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 drivers/net/sfc/sfc_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 2db0d000c3..07b2bd4ce5 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2252,7 +2252,6 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
 
 	/* Copy PCI device info to the dev->data */
 	rte_eth_copy_pci_info(dev, pci_dev);
-	dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
 	dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
 
 	rc = sfc_kvargs_parse(sa);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-10-14 22:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 14:16 [dpdk-dev] [PATCH] net/sfc: remove queue xstats auto-fill flag Andrew Rybchenko
2021-09-28 16:48 ` [dpdk-dev] [PATCH v2] drivers/net: " Andrew Rybchenko
2021-09-28 17:10   ` Stephen Hemminger
2021-09-29  6:38     ` Andrew Rybchenko
2021-09-30 13:00       ` Ferruh Yigit
2021-09-30 13:45         ` Andrew Rybchenko
2021-09-30 13:50           ` Andrew Rybchenko
2021-10-14 22:16             ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-10-14 22:19   ` [dpdk-dev] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).