From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D96EAA0548; Thu, 1 Apr 2021 17:15:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6118F1410C4; Thu, 1 Apr 2021 17:15:50 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7BA4F1410B1 for ; Thu, 1 Apr 2021 17:15:48 +0200 (CEST) IronPort-SDR: roBVOEFQrJ6HWL7C3vBAvezgANqzeYDLz/cBQ1mOPEBAIO4HQSxNc8MHrmJIb2mohMVZgD9b6b bgIBZc6t9/oA== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="191744458" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="191744458" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 08:15:46 -0700 IronPort-SDR: 4NfGEzwB9AT/j4pQbpCGEidOLOIq1El47Vn/SYZEATsaMf+cB1IEferp6iRB24c4OI8hu6mU+K RcaCQsKF4F2A== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="456025739" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.245]) ([10.213.201.245]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 08:15:43 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru References: <1616830688-65506-1-git-send-email-humin29@huawei.com> <1616830688-65506-2-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <040f135d-5832-cfa0-68bc-29e43b4c18f3@intel.com> Date: Thu, 1 Apr 2021 16:15:39 +0100 MIME-Version: 1.0 In-Reply-To: <1616830688-65506-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: fix miss input validation in module EEPROM dump API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: > From: Chengchang Tang > > The validity verification of input parameters should be performed at > API layer, not in the PMD. > > Fixes: 3a18c44b45df ("ethdev: add access to EEPROM") > Fixes: 40ff8b305ab8 ("net/e1000: add module EEPROM callbacks for e1000") > Fixes: f2088e785cca ("net/i40e: fix dereference before check when getting EEPROM") > Fixes: b74d0cd43e37 ("net/ixgbe: add module EEPROM callbacks for ixgbe") > Fixes: 8a6a09f853a0 ("net/mlx5: support reading module EEPROM data") > Fixes: 58f6f93c34c1 ("net/octeontx2: add module EEPROM dump") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit